Fix GC static analyzer error

timholy · timholy · commit e42e25aa24bd · 2020-05-06T07:46:54.000-05:00
diff --git a/src/gf.c b/src/gf.c
@@ -1485,11 +1485,15 @@ static void update_max_args(jl_methtable_t *mt, jl_value_t *type)
         mt->max_args = na;
 }
 
-static jl_array_t *_jl_debug_method_invalidation = NULL;
+jl_array_t *_jl_debug_method_invalidation = NULL;
 JL_DLLEXPORT jl_value_t *jl_debug_method_invalidation(int state)
 {
     if (state) {
+        if (_jl_debug_method_invalidation)
+            return (jl_value_t*) _jl_debug_method_invalidation;
+        JL_GC_PUSH1(&_jl_debug_method_invalidation);
         _jl_debug_method_invalidation = jl_alloc_array_1d(jl_array_any_type, 0);
+        JL_GC_POP();
         return (jl_value_t*) _jl_debug_method_invalidation;
     }
     _jl_debug_method_invalidation = NULL;

Original file line number	Diff line number	Diff line change
`@@ -1485,11 +1485,15 @@ static void update_max_args(jl_methtable_t mt, jl_value_t type)`
`1485`	`1485`	`mt->max_args = na;`
`1486`	`1486`	`}`
`1487`	`1487`
`1488`		`-static jl_array_t *_jl_debug_method_invalidation = NULL;`
	`1488`	`+jl_array_t *_jl_debug_method_invalidation = NULL;`
`1489`	`1489`	`JL_DLLEXPORT jl_value_t *jl_debug_method_invalidation(int state)`
`1490`	`1490`	`{`
`1491`	`1491`	`if (state) {`
	`1492`	`+ if (_jl_debug_method_invalidation)`
	`1493`	`+ return (jl_value_t*) _jl_debug_method_invalidation;`
	`1494`	`+ JL_GC_PUSH1(&_jl_debug_method_invalidation);`
`1492`	`1495`	`_jl_debug_method_invalidation = jl_alloc_array_1d(jl_array_any_type, 0);`
	`1496`	`+ JL_GC_POP();`
`1493`	`1497`	`return (jl_value_t*) _jl_debug_method_invalidation;`
`1494`	`1498`	`}`
`1495`	`1499`	`_jl_debug_method_invalidation = NULL;`