Fix Clang 10 source build (#37824)

Author: Keno

deps/checksums/clang-10.0.1.src.tar.xz/md5

@@ -0,0 +1 @@
+6c8b56f531876fd24e06257a2d8ce422

deps/checksums/clang-10.0.1.src.tar.xz/sha512

@@ -0,0 +1 @@
+c6712d491ce5e166ef72724cf855d742d88da825ffc25585612d7f2eb7770343e3ae48fa78e0af3e5d5efdde3a9686a7361dac3b546a4378de22448ea6e4026c

deps/checksums/compiler-rt-10.0.1.src.tar.xz/md5

@@ -0,0 +1 @@
+970835d14e9c08a68c4b2ff3931bada7

deps/checksums/compiler-rt-10.0.1.src.tar.xz/sha512

@@ -0,0 +1 @@
+a1d2e3f5ad529a04f87059903b31fc3c9803cd86f44aed1aebd87ce7e423d8dd2b6776be12e85a0374a6215f581420438d224c130aad5e6355920af32c02aa7b

deps/llvm.mk

@@ -69,7 +69,11 @@ LLVM_LLDB_TAR:=$(SRCCACHE)/lldb-$(LLVM_TAR_EXT)
 endif # BUILD_LLDB
 
 ifeq ($(BUILD_LLVM_CLANG),1)
+ifeq ($(LLVM_VER_MAJ).$(LLVM_VER_MIN),9.0)
 LLVM_CLANG_TAR:=$(SRCCACHE)/cfe-$(LLVM_TAR_EXT)
+else
+LLVM_CLANG_TAR:=$(SRCCACHE)/clang-$(LLVM_TAR_EXT)
+endif
 LLVM_COMPILER_RT_TAR:=$(SRCCACHE)/compiler-rt-$(LLVM_TAR_EXT)
 else
 LLVM_CLANG_TAR:=
@@ -487,6 +491,9 @@ $(eval $(call LLVM_PATCH,llvm-D84031)) # remove for LLVM 12
 $(eval $(call LLVM_PATCH,llvm-10-D85553)) # remove for LLVM 12
 $(eval $(call LLVM_PATCH,llvm-10-r_aarch64_prel32)) # remove for LLVM 12
 $(eval $(call LLVM_PATCH,llvm-10-r_ppc_rel)) # remove for LLVM 12
+ifeq ($(BUILD_LLVM_CLANG),1)
+$(eval $(call LLVM_PATCH,llvm-D88630-clang-cmake))
+endif
 endif # LLVM_VER 10.0
 
 ifeq ($(LLVM_VER_SHORT),11.0)
@@ -501,6 +508,9 @@ $(eval $(call LLVM_PATCH,llvm-julia-tsan-custom-as))
 $(eval $(call LLVM_PATCH,llvm-D80101)) # remove for LLVM 12
 $(eval $(call LLVM_PATCH,llvm-D84031)) # remove for LLVM 12
 $(eval $(call LLVM_PATCH,llvm-10-D85553)) # remove for LLVM 12
+ifeq ($(BUILD_LLVM_CLANG),1)
+$(eval $(call LLVM_PATCH,llvm-D88630-clang-cmake))
+endif
 endif # LLVM_VER 11.0
 
 

deps/patches/llvm-D88630-clang-cmake.patch

@@ -0,0 +1,29 @@
+commit 9c682bac219e28afc73e25e7089b553ecd1ca0f6
+Author: Keno Fischer <keno@juliacomputing.com>
+Date:   Wed Sep 30 22:15:40 2020 -0400
+
+    [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR
+    
+    Otherwise clang installs all of its tools into `bin/` while
+    LLVM installs its tools into (LLVM_TOOLS_INSTALL_DIR).
+    I could swear this used to work (and in fact the julia build system
+    assumes it), but I can't pin down a specific commit that would
+    have broken this, and julia has been relying on pre-compiled binaries
+    for a while now (that don't use this setting), so it may have been
+    broken for quite a while.
+    
+    Differential Revision: https://reviews.llvm.org/D88630
+
+diff --git a/tools/clang/cmake/modules/AddClang.cmake b/tools/clang/cmake/modules/AddClang.cmake
+index 704278a0e93..a455365cabf 100644
+--- a/tools/clang/cmake/modules/AddClang.cmake
++++ b/tools/clang/cmake/modules/AddClang.cmake
+@@ -170,7 +170,7 @@ macro(add_clang_tool name)
+ 
+     install(TARGETS ${name}
+       ${export_to_clangtargets}
+-      RUNTIME DESTINATION bin
++      RUNTIME DESTINATION ${LLVM_TOOLS_INSTALL_DIR}
+       COMPONENT ${name})
+ 
+     if(NOT LLVM_ENABLE_IDE)