Merge pull request #23529 from Sacha0/depwritecsv

deprecate writecsv in favor of writedlm

Author: JeffBezanson

NEWS.md

@@ -279,6 +279,9 @@ Deprecated or removed
   * The keyword `immutable` is fully deprecated to `struct`, and
     `type` is fully deprecated to `mutable struct` ([#19157], [#20418]).
 
+  * `writecsv(io, a; opts...)` has been deprecated in favor of
+    `writedlm(io, a, ','; opts...)` ([#23529]).
+
   * The method `srand(rng, filename, n=4)` has been deprecated ([#21359]).
 
   * The `cholfact`/`cholfact!` methods that accepted an `uplo` symbol have been deprecated

base/datafmt.jl

@@ -6,7 +6,7 @@ module DataFmt
 
 import Base: _default_delims, tryparse_internal, show
 
-export countlines, readdlm, readcsv, writedlm, writecsv
+export countlines, readdlm, readcsv, writedlm
 
 invalid_dlm(::Type{Char})   = reinterpret(Char, 0xfffffffe)
 invalid_dlm(::Type{UInt8})  = 0xfe
@@ -703,13 +703,6 @@ tab-delimited text to `f` by either `writedlm(f, [x y])` or by `writedlm(f, zip(
 """
 writedlm(io, a; opts...) = writedlm(io, a, '\t'; opts...)
 
-"""
-    writecsv(filename, A; opts)
-
-Equivalent to [`writedlm`](@ref) with `delim` set to comma.
-"""
-writecsv(io, a; opts...) = writedlm(io, a, ','; opts...)
-
 show(io::IO, ::MIME"text/csv", a) = writedlm(io, a, ',')
 show(io::IO, ::MIME"text/tab-separated-values", a) = writedlm(io, a, '\t')
 

base/deprecated.jl

@@ -1726,6 +1726,9 @@ import .LinAlg: diagm
 @deprecate_binding φ          MathConstants.φ
 @deprecate_binding golden     MathConstants.golden
 
+# deprecate writecsv
+@deprecate writecsv(io, a; opts...) writedlm(io, a, ','; opts...)
+
 # PR #23271
 function IOContext(io::IO; kws...)
     depwarn("IOContext(io, k=v, ...) is deprecated, use IOContext(io, :k => v, ...) instead.", :IOContext)

base/exports.jl

@@ -1073,7 +1073,6 @@ export
     unmark,
     watch_file,
     write,
-    writecsv,
     writedlm,
     TCPSocket,
     UDPSocket,

doc/src/stdlib/io-network.md

@@ -84,7 +84,6 @@ Base.DataFmt.readdlm(::Any, ::Type)
 Base.DataFmt.readdlm(::Any)
 Base.DataFmt.writedlm
 Base.DataFmt.readcsv
-Base.DataFmt.writecsv
 Base.Base64.Base64EncodePipe
 Base.Base64.Base64DecodePipe
 Base.Base64.base64encode

test/perf/kernel/perf.jl

@@ -102,7 +102,7 @@ d = randn(len)
 
 @timeit (for n in 1:10; a = arith_vectorized(b,c,d); end) "vectorize" "Vectorized arithmetic"
 
-writecsv("random.csv", rand(100000,4))
+writedlm("random.csv", rand(100000, 4), ',')
 
 function parsecsv()
     for line in eachline("random.csv")