Skip to content

Commit ad9eac9

Browse files
lkapelevichKristofferC
authored andcommitted
[LinearAlgebra] Correct liblapack binding (#40170)
* [LinearAlgebra] Correct binding * fix English * bring liblapack back into BLAS module (cherry picked from commit 65e1348)
1 parent cfc8928 commit ad9eac9

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

stdlib/LinearAlgebra/src/lapack.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ Interfaces to LAPACK subroutines.
77

88
const liblapack = Base.liblapack_name
99

10+
# Legacy binding maintained for backwards-compatibility but new packages
11+
# should not look at this, instead preferring to parse the output
12+
# of BLAS.get_config()
13+
const liblapack = libblastrampoline
14+
1015
import ..LinearAlgebra.BLAS.@blasfunc
1116

1217
import ..LinearAlgebra: BlasFloat, BlasInt, LAPACKException,

stdlib/LinearAlgebra/test/blas.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -617,4 +617,8 @@ end
617617
end
618618
end
619619

620+
# https://github.com/JuliaLang/julia/pull/39845
621+
@test LinearAlgebra.BLAS.libblas == "libblastrampoline"
622+
@test LinearAlgebra.BLAS.liblapack == "libblastrampoline"
623+
620624
end # module TestBLAS

stdlib/LinearAlgebra/test/lapack.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -702,4 +702,7 @@ let A = [NaN NaN; NaN NaN]
702702
@test_throws ArgumentError eigen(A)
703703
end
704704

705+
# # https://github.com/JuliaLang/julia/pull/39845
706+
@test LinearAlgebra.LAPACK.liblapack == "libblastrampoline"
707+
705708
end # module TestLAPACK

0 commit comments

Comments
 (0)