Skip to content

Commit abeb68f

Browse files
make rationalize default to use Int on Irrational (and Real) (#46656)
Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
1 parent 649982a commit abeb68f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

base/rational.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ function rationalize(::Type{T}, x::Union{AbstractFloat, Rational}, tol::Real) wh
245245
end
246246
end
247247
rationalize(::Type{T}, x::AbstractFloat; tol::Real = eps(x)) where {T<:Integer} = rationalize(T, x, tol)
248-
rationalize(x::AbstractFloat; kvs...) = rationalize(Int, x; kvs...)
248+
rationalize(x::Real; kvs...) = rationalize(Int, x; kvs...)
249249
rationalize(::Type{T}, x::Complex; kvs...) where {T<:Integer} = Complex(rationalize(T, x.re; kvs...), rationalize(T, x.im; kvs...))
250250
rationalize(x::Complex; kvs...) = Complex(rationalize(Int, x.re; kvs...), rationalize(Int, x.im; kvs...))
251251
rationalize(::Type{T}, x::Rational; tol::Real = 0) where {T<:Integer} = rationalize(T, x, tol)

test/rational.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@ end
542542
100798//32085
543543
103993//33102
544544
312689//99532 ]
545+
@test rationalize(pi) === rationalize(BigFloat(pi))
545546
end
546547

547548
@testset "issue #12536" begin

0 commit comments

Comments
 (0)