Skip to content

Commit 88d683c

Browse files
authored
Remove reference to LoopVectorization in PGO Makefile (#54175)
Noting that the profile counters aren't atomic seems useful so I threw that in as well.
1 parent f1b5675 commit 88d683c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

contrib/pgo-lto/Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ LLVM_OBJCOPY:=$(STAGE0_TOOLS)llvm-objcopy
1818
# When building a single libLLVM.so we need to increase -vp-counters-per-site
1919
# significantly
2020
COUNTERS_PER_SITE:=6
21+
# Note: profile counters are not atomic by default, https://discourse.llvm.org/t/profile-guided-optimization-pgo-related-questions-and-suggestions/75232/5
2122

22-
AFTER_STAGE1_MESSAGE:='Run `make clean-profiles` to start with a clean slate. $\
23-
Then run Julia to collect realistic profile data, for example: `$(STAGE1_BUILD)/julia -O3 -e $\
24-
'\''using Pkg; Pkg.add("LoopVectorization"); Pkg.test("LoopVectorization")'\''`. This $\
25-
should produce about 15MB of data in $(PROFILE_DIR). Note that running extensive $\
26-
scripts may result in counter overflows, which can be detected by running $\
23+
AFTER_STAGE1_MESSAGE:='You can now optionally collect more profiling data for use in PGO by running Julia $\
24+
with an appropriate workload. If you wish, run `make clean_profiles` before doing so to remove any profiling data $\
25+
generated by building Julia. You should end up with about 15MB of data in $(PGO_PROFILE_DIR). $\
26+
Note that running extensive scripts may result in counter overflows, which can be detected by running $\
2727
`make top`. Afterwards run `make stage2`.'
2828

2929
TOOLCHAIN_FLAGS = $\

0 commit comments

Comments
 (0)