Skip to content

Commit 855a08b

Browse files
authored
Remove unnecessary jl_gc_wb calls (#36137)
1 parent 912a8ed commit 855a08b

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

src/dump.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1926,7 +1926,6 @@ static void jl_insert_backedges(jl_array_t *list, jl_array_t *targets)
19261926
if (_jl_debug_method_invalidation) {
19271927
jl_array_ptr_1d_push(_jl_debug_method_invalidation, (jl_value_t*)caller);
19281928
loctag = jl_cstr_to_string("insert_backedges");
1929-
jl_gc_wb(_jl_debug_method_invalidation, loctag);
19301929
jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag);
19311930
}
19321931
}

src/gf.c

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,6 @@ static void invalidate_method_instance(jl_method_instance_t *replaced, size_t ma
15101510
jl_array_ptr_1d_push(_jl_debug_method_invalidation, (jl_value_t*)replaced);
15111511
boxeddepth = jl_box_int32(depth);
15121512
jl_array_ptr_1d_push(_jl_debug_method_invalidation, boxeddepth);
1513-
jl_gc_wb(_jl_debug_method_invalidation, boxeddepth);
15141513
JL_GC_POP();
15151514
}
15161515
if (!jl_is_method(replaced->def.method))
@@ -1643,7 +1642,6 @@ static int invalidate_mt_cache(jl_typemap_entry_t *oldentry, void *closure0)
16431642
JL_GC_PUSH1(&loctag);
16441643
jl_array_ptr_1d_push(_jl_debug_method_invalidation, (jl_value_t*)mi);
16451644
loctag = jl_cstr_to_string("invalidate_mt_cache");
1646-
jl_gc_wb(_jl_debug_method_invalidation, loctag);
16471645
jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag);
16481646
JL_GC_POP();
16491647
}
@@ -1703,20 +1701,16 @@ JL_DLLEXPORT void jl_method_table_disable(jl_methtable_t *mt, jl_method_t *metho
17031701
invalidated = 1;
17041702
if (invalidate_backedges(mi, methodentry->max_world))
17051703
if (_jl_debug_method_invalidation) {
1706-
if (!loctag) {
1704+
if (!loctag)
17071705
loctag = jl_cstr_to_string("jl_method_table_disable");
1708-
jl_gc_wb(_jl_debug_method_invalidation, loctag);
1709-
}
17101706
jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag);
17111707
}
17121708
}
17131709
}
17141710
if (invalidated && _jl_debug_method_invalidation) {
17151711
jl_array_ptr_1d_push(_jl_debug_method_invalidation, (jl_value_t*)method);
1716-
if (!loctag) {
1712+
if (!loctag)
17171713
loctag = jl_cstr_to_string("jl_method_table_disable");
1718-
jl_gc_wb(_jl_debug_method_invalidation, loctag);
1719-
}
17201714
jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag);
17211715
}
17221716
JL_GC_POP();
@@ -1815,10 +1809,8 @@ JL_DLLEXPORT void jl_method_table_insert(jl_methtable_t *mt, jl_method_t *method
18151809
invalidated = 1;
18161810
if (_jl_debug_method_invalidation) {
18171811
jl_array_ptr_1d_push(_jl_debug_method_invalidation, (jl_value_t*)mi);
1818-
if (!loctag) {
1812+
if (!loctag)
18191813
loctag = jl_cstr_to_string("jl_method_table_insert");
1820-
jl_gc_wb(_jl_debug_method_invalidation, loctag);
1821-
}
18221814
jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag);
18231815
}
18241816
}
@@ -1827,10 +1819,8 @@ JL_DLLEXPORT void jl_method_table_insert(jl_methtable_t *mt, jl_method_t *method
18271819
}
18281820
if (invalidated && _jl_debug_method_invalidation) {
18291821
jl_array_ptr_1d_push(_jl_debug_method_invalidation, (jl_value_t*)method);
1830-
if (!loctag) {
1822+
if (!loctag)
18311823
loctag = jl_cstr_to_string("jl_method_table_insert");
1832-
jl_gc_wb(_jl_debug_method_invalidation, loctag);
1833-
}
18341824
jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag);
18351825
}
18361826
update_max_args(mt, type);

0 commit comments

Comments
 (0)