Skip to content

Commit 72cba22

Browse files
author
KristofferC
committed
Revert "effects: fix Base.@_noub_meta (#56061)"
This reverts commit a9fd6db.
1 parent 4cf3975 commit 72cba22

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

base/essentials.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,7 @@ macro _noub_meta()
348348
#=:inaccessiblememonly=#false,
349349
#=:noub=#true,
350350
#=:noub_if_noinbounds=#false,
351-
#=:consistent_overlay=#false,
352-
#=:nortcall=#false))
351+
#=:consistent_overlay=#false))
353352
end
354353
# can be used in place of `@assume_effects :notaskstate` (supposed to be used for bootstrapping)
355354
macro _notaskstate_meta()

src/method.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,8 +370,6 @@ static void jl_code_info_set_ir(jl_code_info_t *li, jl_expr_t *ir)
370370
if (consistent_overlay) li->purity.overrides.ipo_consistent_overlay = consistent_overlay;
371371
int8_t nortcall = jl_unbox_bool(jl_exprarg(ma, 10));
372372
if (nortcall) li->purity.overrides.ipo_nortcall = nortcall;
373-
} else {
374-
assert(jl_expr_nargs(ma) == 0);
375373
}
376374
}
377375
else

test/compiler/effects.jl

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -858,12 +858,7 @@ end
858858
# @test !Core.Compiler.is_nothrow(effects)
859859
# end
860860
#end
861-
862-
@test Core.Compiler.is_noub(Base.infer_effects(Base._growbeg!, (Vector{Int}, Int)))
863-
@test Core.Compiler.is_noub(Base.infer_effects(Base._growbeg!, (Vector{Any}, Int)))
864-
@test Core.Compiler.is_noub(Base.infer_effects(Base._growend!, (Vector{Int}, Int)))
865-
@test Core.Compiler.is_noub(Base.infer_effects(Base._growend!, (Vector{Any}, Int)))
866-
861+
#
867862
# tuple indexing
868863
# --------------
869864

0 commit comments

Comments
 (0)