Test dimensional reductions

Author: TotalVerb

base/reducedim.jl

@@ -117,8 +117,8 @@ reducedim_init(f, op::typeof(|), A::AbstractArray, region) = reducedim_initarray
 # specialize to make initialization more efficient for common cases
 
 let
-    const BitIntFloat = Union{BitInteger, Math.IEEEFloat}
-    const T = Union{
+    BitIntFloat = Union{BitInteger, Math.IEEEFloat}
+    T = Union{
         [AbstractArray{t} for t in uniontypes(BitIntFloat)]...,
         [AbstractArray{Complex{t}} for t in uniontypes(BitIntFloat)]...}
 
@@ -586,7 +586,6 @@ for (fname, op) in [(:sum, :+), (:prod, :*),
     end
     fname! = Symbol(fname, '!')
     @eval begin
-        # TODO: check this
         $(fname!)(f::Function, r::AbstractArray, A::AbstractArray; init::Bool=true) =
             mapreducedim!(f, $(op), initarray!(r, $(op), init), A)
         $(fname!)(r::AbstractArray, A::AbstractArray; init::Bool=true) = $(fname!)(identity, r, A; init=init)

test/reducedim.jl

@@ -154,3 +154,11 @@ for region in Any[-1, 0, (-1, 2), [0, 1], (1,-2,3), [0 1;
     @test_throws ArgumentError maximum(abs, Areduc, region)
     @test_throws ArgumentError minimum(abs, Areduc, region)
 end
+
+# check type of result
+under_test = [UInt8, Int8, Int32, Int64, BigInt]
+@testset "type of sum(::Array{$T}" for T in under_test
+    result = sum(T[1 2 3; 4 5 6; 7 8 9], 2)
+    @test result == hcat([6, 15, 24])
+    @test eltype(result) === typeof(promote_sys_size(zero(T)))
+end