Check return value of SystemFunction036 (#34429)

In both places we call it. Also tabs-to-spaces for the new code
to match the formatting of the rest of the code.

Author: Keno

base/file.jl

@@ -519,16 +519,18 @@ end
 
 # generate a random string from random bytes
 function _rand_string()
-	nchars = 10
-	A = Vector{UInt8}(undef, nchars)
-	ccall((:SystemFunction036, :Advapi32), stdcall, UInt8, (Ptr{Cvoid}, UInt32), A, sizeof(A))
-
-	slug = Base.StringVector(10)
-	chars = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
-	for i = 1:nchars
-	    slug[i] = chars[(A[i] % length(chars)) + 1]
-	end
-	return name = String(slug)
+    nchars = 10
+    A = Vector{UInt8}(undef, nchars)
+    windowserror("SystemFunction036 (RtlGenRandom)", 0 == ccall(
+        (:SystemFunction036, :Advapi32), stdcall, UInt8, (Ptr{Cvoid}, UInt32),
+            A, sizeof(A)))
+
+    slug = Base.StringVector(10)
+    chars = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
+    for i = 1:nchars
+        slug[i] = chars[(A[i] % length(chars)) + 1]
+    end
+    return name = String(slug)
 end
 
 function tempname(parent::AbstractString=tempdir(); cleanup::Bool=true)

stdlib/Random/src/RNGs.jl

@@ -43,8 +43,9 @@ end # os-test
 for T in (Bool, BitInteger_types...)
     if Sys.iswindows()
         @eval function rand!(rd::RandomDevice, A::Array{$T}, ::SamplerType{$T})
-            ccall((:SystemFunction036, :Advapi32), stdcall, UInt8, (Ptr{Cvoid}, UInt32),
-                  A, sizeof(A))
+            Base.windowserror("SystemFunction036 (RtlGenRandom)", 0 == ccall(
+                (:SystemFunction036, :Advapi32), stdcall, UInt8, (Ptr{Cvoid}, UInt32),
+                  A, sizeof(A)))
             A
         end
     else