codegen: fix ssa order regression from initializing structs (#52311)

vtjnash · web-flow · commit 08d89eb2cede · 2023-11-26T23:27:43.000-05:00
diff --git a/src/cgutils.cpp b/src/cgutils.cpp
@@ -3733,7 +3733,7 @@ static jl_cgval_t emit_new_struct(jl_codectx_t &ctx, jl_value_t *ty, size_t narg
                 strct = emit_static_alloca(ctx, lt);
                 setName(ctx.emission_context, strct, arg_typename);
                 if (nargs < nf)
-                    ctx.builder.CreateStore(ctx.builder.CreateFreeze(UndefValue::get(lt)), strct);
+                    promotion_point = ctx.builder.CreateStore(ctx.builder.CreateFreeze(UndefValue::get(lt)), strct);
                 if (tracked.count)
                     undef_derived_strct(ctx, strct, sty, ctx.tbaa().tbaa_stack);
             }

Original file line number	Diff line number	Diff line change
`@@ -3733,7 +3733,7 @@ static jl_cgval_t emit_new_struct(jl_codectx_t &ctx, jl_value_t *ty, size_t narg`
`3733`	`3733`	`strct = emit_static_alloca(ctx, lt);`
`3734`	`3734`	`setName(ctx.emission_context, strct, arg_typename);`
`3735`	`3735`	`if (nargs < nf)`
`3736`		`- ctx.builder.CreateStore(ctx.builder.CreateFreeze(UndefValue::get(lt)), strct);`
	`3736`	`+ promotion_point = ctx.builder.CreateStore(ctx.builder.CreateFreeze(UndefValue::get(lt)), strct);`
`3737`	`3737`	`if (tracked.count)`
`3738`	`3738`	`undef_derived_strct(ctx, strct, sty, ctx.tbaa().tbaa_stack);`
`3739`	`3739`	`}`