Merge pull request #35625 from JuliaLang/sf/uv_fs_access

Author: staticfloat

base/file.jl

@@ -989,6 +989,11 @@ Change the permissions mode of `path` to `mode`. Only integer `mode`s (e.g. `0o7
 currently supported. If `recursive=true` and the path is a directory all permissions in
 that directory will be recursively changed.
 Return `path`.
+
+!!! note
+     Prior to Julia 1.5, this did not correctly manipulate filesystem ACLs
+     on Windows, therefore it would only set read-only bits on files.  It
+     now is able to manipulate ACLs.
 """
 function chmod(path::AbstractString, mode::Integer; recursive::Bool=false)
     err = ccall(:jl_fs_chmod, Int32, (Cstring, Cint), path, mode)

base/sysinfo.jl

@@ -438,16 +438,18 @@ const WINDOWS_VISTA_VER = v"6.0"
     Sys.isexecutable(path::String)
 
 Return `true` if the given `path` has executable permissions.
+
+!!! note
+    Prior to Julia 1.5, this did not correctly interrogate filesystem
+    ACLs on Windows, therefore it would return `true` for any
+    file.  From Julia 1.5 on, it correctly determines whether the
+    file is marked as executable or not.
 """
 function isexecutable(path::String)
-    if iswindows()
-        return isfile(path)
-    else
-        # We use `access()` and `X_OK` to determine if a given path is
-        # executable by the current user.  `X_OK` comes from `unistd.h`.
-        X_OK = 0x01
-        ccall(:access, Cint, (Ptr{UInt8}, Cint), path, X_OK) == 0
-    end
+    # We use `access()` and `X_OK` to determine if a given path is
+    # executable by the current user.  `X_OK` comes from `unistd.h`.
+    X_OK = 0x01
+    return ccall(:jl_fs_access, Cint, (Ptr{UInt8}, Cint), path, X_OK) == 0
 end
 isexecutable(path::AbstractString) = isexecutable(String(path))
 

deps/Versions.make

@@ -29,7 +29,7 @@ CURL_BB_REL = 1
 LIBGIT2_VER = 0.28.2
 LIBGIT2_BB_REL = 1
 LIBUV_VER = 1.29.1
-LIBUV_BB_REL = 0
+LIBUV_BB_REL = 6
 OBJCONV_VER = 2.49.0
 OBJCONV_BB_REL = 0
 ZLIB_VER = 1.2.11