Skip to content

Revert "Cleanup and generalize functions of Hermitian matrices (#1340)" #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 13, 2025

This reverts commit 611395d.

Unfortunately, this PR introduced some method ambiguities that weren't caught by the CI, as the ambiguity test was broken. After the fix in #1349, this now causes test failures on master (https://buildkite.com/julialang/linearalgebra-dot-jl/builds/740#0196c86e-2d8c-42c2-b9ae-a2143427f43e).

Please re-land the PR after fixing the ambiguities.

CC: @araujoms

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.75%. Comparing base (0b46d5c) to head (1143a11).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/symmetric.jl 97.29% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1357   +/-   ##
=======================================
  Coverage   93.74%   93.75%           
=======================================
  Files          34       34           
  Lines       15721    15755   +34     
=======================================
+ Hits        14738    14771   +33     
- Misses        983      984    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 3e4d569 into master May 13, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/revertsympow branch May 13, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant