Skip to content

Prune LinearAlgebra module in ambiguity test #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 12, 2025

The ambiguity check was being run in a separate process, but it was not pruning the LinearAlgebra module. This was therefore not testing for ambiguities in the latest code, but the one in the sysimg.

The PR would be able to replicate the test failure seen in https://buildkite.com/julialang/julia-master/builds/47424#0196c03a-2230-4d64-b404-e04dbfc76c3f

@jishnub
Copy link
Member Author

jishnub commented May 12, 2025

I don't understand the ambiguities here, but splitting the methods seems to resolve it.
The ambiguities on master (and on 79ba4de) were

julia> Test.detect_ambiguities(LinearAlgebra)
2-element Vector{Tuple{Method, Method}}:
 (/(u::Transpose{T, <:AbstractVector} where T, A::AbstractMatrix) @ LinearAlgebra ~/Dropbox/JuliaPackages/LinearAlgebra.jl/src/adjtrans.jl:543, /(B::AbstractMatrix, H::Union{Adjoint{<:Any, <:UpperHessenberg}, Transpose{<:Any, <:UpperHessenberg}, UpperHessenberg}) @ LinearAlgebra ~/Dropbox/JuliaPackages/LinearAlgebra.jl/src/hessenberg.jl:185)
 (/(u::Adjoint{T, <:AbstractVector} where T, A::AbstractMatrix) @ LinearAlgebra ~/Dropbox/JuliaPackages/LinearAlgebra.jl/src/adjtrans.jl:542, /(B::AbstractMatrix, H::Union{Adjoint{<:Any, <:UpperHessenberg}, Transpose{<:Any, <:UpperHessenberg}, UpperHessenberg}) @ LinearAlgebra ~/Dropbox/JuliaPackages/LinearAlgebra.jl/src/hessenberg.jl:185)

However, the following all work:

julia> U = UpperHessenberg(rand(4,4));

julia> (1:4)' / U;

julia> (1:4)' / U';

julia> (1:4)' / transpose(U);

julia> transpose(1:4) / U';

julia> transpose(1:4) / transpose(U);

julia> transpose(1:4) / U;

as there are specialized methods for these:

# fix method ambiguities for right division, from adjtrans.jl:
/(u::AdjointAbsVec, A::UpperHessenberg) = adjoint(adjoint(A) \ u.parent)
/(u::TransposeAbsVec, A::UpperHessenberg) = transpose(transpose(A) \ u.parent)
/(u::AdjointAbsVec, A::Adjoint{<:Any,<:UpperHessenberg}) = adjoint(adjoint(A) \ u.parent)
/(u::TransposeAbsVec, A::Transpose{<:Any,<:UpperHessenberg}) = transpose(transpose(A) \ u.parent)
/(u::AdjointAbsVec, A::Transpose{<:Any,<:UpperHessenberg}) = adjoint(conj(A.parent) \ u.parent) # technically should be adjoint(copy(adjoint(copy(A))) \ u.parent)
/(u::TransposeAbsVec, A::Adjoint{<:Any,<:UpperHessenberg}) = transpose(conj(A.parent) \ u.parent)

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (2cb1e98) to head (376d885).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          34       34           
  Lines       15753    15755    +2     
=======================================
+ Hits        14768    14770    +2     
  Misses        985      985           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub added the backport 1.12 Change should be backported to release-1.12 label May 12, 2025
jishnub added a commit that referenced this pull request May 13, 2025
This cherry-picks 3c19c34 from #1349,
which makes this easier to backport
@jishnub jishnub force-pushed the jishnub/ambiguity branch from 848f131 to 376d885 Compare May 13, 2025 06:20
@jishnub jishnub mentioned this pull request May 13, 2025
27 tasks
@jishnub jishnub merged commit 0b46d5c into master May 13, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/ambiguity branch May 13, 2025 06:56
jishnub added a commit that referenced this pull request May 13, 2025
The ambiguity check was being run in a separate process, but it was not
pruning the `LinearAlgebra` module. This was therefore not testing for
ambiguities in the latest code, but the one in the sysimg.

The PR would be able to replicate the test failure seen in
https://buildkite.com/julialang/julia-master/builds/47424#0196c03a-2230-4d64-b404-e04dbfc76c3f

(cherry picked from commit 0b46d5c)
jishnub added a commit that referenced this pull request May 13, 2025
…" (#1357)

This reverts commit 611395d.

Unfortunately, this PR introduced some method ambiguities that weren't
caught by the CI, as the ambiguity test was broken. After the fix in
#1349, this now causes test failures on master
(https://buildkite.com/julialang/linearalgebra-dot-jl/builds/740#0196c86e-2d8c-42c2-b9ae-a2143427f43e).

Please re-land the PR after fixing the ambiguities.

CC: @araujoms
jishnub added a commit that referenced this pull request May 26, 2025
Backported PRs:
- [x] #1209 <!-- Remove `LinearAlgebra` qualifications in `cholesky.jl`
-->
- [x] #1230 <!-- Avoid materializing `diag` in `Diagonal` `kron` -->
- [x] #1240 <!-- Reduce `stable_muladdmul` branches in `generic
matvecmul!` -->
- [x] #1247 <!-- fix dispatch to herk -->
- [x] #1255 <!-- use smaller matrix size in `peakflops` on 32-bit -->
- [x] #1310 <!-- Only `@noinline` error path in `matmul_size_check` -->
- [x] #1267 <!-- Refine column ranges in `_isbanded_impl` -->
- [x] #1320 <!-- Copy matrices in `triu`/`tril` if no zero exists for
the `eltype` -->
- [x] #1324 <!-- Fix empty `Tridiagonal` broadcast -->
- [x] #1327 <!-- `iszero` check in hessenberg setindex -->
- [x] #1326 <!-- Fix multiplication with empty `HessenbergQ` -->
- [x] #1332 <!-- Unwrap triangular matrices in broadcast -->
- [x] #1337 <!-- Change `1:size` to `axes` in bidiag mul -->
- [x] #1342 <!-- `Char` uplo in `Bidiagonal` constructor -->
- [x] #1344 <!-- Update the docstring of ldiv! -->
- [x] #1335 <!-- Test: prune old LA based on ENV variable -->
- [x] #1346 <!-- Fix scaling unit triangular matrices -->
- [x] #1355 <!-- Add compat notice for `diagview` -->
- [x] #1349 <!-- Prune `LinearAlgebra` module in ambiguity test -->

Contains multiple commits, manual intervention needed:
- [x] #1238 <!-- Ensure positive-definite matrix in lapack posv test -->
- [x] #1298 <!-- Add `diagm` example -->
- [x] #1312 <!-- WIP: Try use method deletion instead of custom sysimage
-->
- [x] #1333 <!-- Make `fillstored!` public -->
- [x] #1331 <!-- Document SingularException throw for
inv(::AbstractMatrix) -->
- [x] #1350 <!-- Fix copy for partly initialized unit triangular -->

Non-merged PRs with backport label:
- [x] #1352 <!-- log for dense diagonal matrix with negative elements
-->
- [ ] #1305 <!-- Bounds-checking in triangular indexing branches -->

---------

Co-authored-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
Co-authored-by: WalterMadelim <143272683+WalterMadelim@users.noreply.github.com>
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
@jishnub jishnub removed the backport 1.12 Change should be backported to release-1.12 label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant