Skip to content

Forward _tri(l/r)div! to parent of triangular #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 11, 2025

These loop over the stored triangular halves, so we may forward the operations to the parents. These are also internal methods that are not applied to unit triangular matrices, so we restrict these to UpperTriangular and LowerTriangular matrices in this PR. This makes it straightforward to forward the operations to the parent.

@dkarrasch
Copy link
Member

dkarrasch commented May 11, 2025

What happens in the [unit] cases that you removed here?

@jishnub
Copy link
Member Author

jishnub commented May 12, 2025

The unit triangular methods re-wrap the parents in a standard triangular wrapper, and call the corresponding methods. However, it seems more work needs to be done here to avoid errors from partly initialized parents. In any case, these methods are not called in the unit triangular cases.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (3393398) to head (7a5cfca).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
+ Coverage   93.74%   93.88%   +0.14%     
==========================================
  Files          34       34              
  Lines       15752    16084     +332     
==========================================
+ Hits        14766    15100     +334     
+ Misses        986      984       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 335a1ee into master May 16, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/trilrdiv branch May 16, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants