Skip to content

Commit a305c67

Browse files
authored
Change constructions to assertions in structured broadcast tests (#1330)
The broadcast operation should already be returning the correct type, and we may type-assert the result instead of constructing an instance from it.
1 parent b14390e commit a305c67

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/structuredbroadcast.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,13 @@ end
137137
= UpperTriangular(rand(N,N))
138138
M = Matrix(rand(N,N))
139139

140-
@test broadcast!(sin, copy(D), D) == Diagonal(sin.(D))
141-
@test broadcast!(sin, copy(Bu), Bu) == Bidiagonal(sin.(Bu), :U)
142-
@test broadcast!(sin, copy(Bl), Bl) == Bidiagonal(sin.(Bl), :L)
143-
@test broadcast!(sin, copy(T), T) == Tridiagonal(sin.(T))
144-
@test broadcast!(sin, copy(◣), ◣) == LowerTriangular(sin.(◣))
145-
@test broadcast!(sin, copy(◥), ◥) == UpperTriangular(sin.(◥))
146-
@test broadcast!(sin, copy(M), M) == Matrix(sin.(M))
140+
@test broadcast!(sin, copy(D), D)::Diagonal == sin.(D)::Diagonal
141+
@test broadcast!(sin, copy(Bu), Bu)::Bidiagonal == sin.(Bu)::Bidiagonal
142+
@test broadcast!(sin, copy(Bl), Bl)::Bidiagonal == sin.(Bl)::Bidiagonal
143+
@test broadcast!(sin, copy(T), T)::Tridiagonal == sin.(T)::Tridiagonal
144+
@test broadcast!(sin, copy(◣), ◣)::LowerTriangular == sin.(◣)::LowerTriangular
145+
@test broadcast!(sin, copy(◥), ◥)::UpperTriangular == sin.(◥)::UpperTriangular
146+
@test broadcast!(sin, copy(M), M)::Matrix == sin.(M)::Matrix
147147
@test broadcast!(*, copy(D), D, A) == Diagonal(broadcast(*, D, A))
148148
@test broadcast!(*, copy(Bu), Bu, A) == Bidiagonal(broadcast(*, Bu, A), :U)
149149
@test broadcast!(*, copy(Bl), Bl, A) == Bidiagonal(broadcast(*, Bl, A), :L)

0 commit comments

Comments
 (0)