Skip to content

Commit 21e4346

Browse files
committed
Revert "add missing methods for division of Hessenberg matrices (#1322)"
This reverts commit 6d36322.
1 parent 150e2fd commit 21e4346

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

src/hessenberg.jl

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -177,29 +177,6 @@ function \(U::UnitUpperTriangular, H::UpperHessenberg)
177177
UpperHessenberg(HH)
178178
end
179179

180-
function (\)(H::Union{UpperHessenberg,AdjOrTrans{<:Any,<:UpperHessenberg}}, B::AbstractVecOrMat)
181-
TFB = typeof(oneunit(eltype(H)) \ oneunit(eltype(B)))
182-
return ldiv!(H, copy_similar(B, TFB))
183-
end
184-
185-
function (/)(B::AbstractMatrix, H::Union{UpperHessenberg,AdjOrTrans{<:Any,<:UpperHessenberg}})
186-
TFB = typeof(oneunit(eltype(B)) / oneunit(eltype(H)))
187-
return rdiv!(copy_similar(B, TFB), H)
188-
end
189-
190-
ldiv!(H::AdjOrTrans{<:Any,<:UpperHessenberg}, B::AbstractVecOrMat) =
191-
(rdiv!(wrapperop(H)(B), parent(H)); B)
192-
rdiv!(B::AbstractVecOrMat, H::AdjOrTrans{<:Any,<:UpperHessenberg}) =
193-
(ldiv!(parent(H), wrapperop(H)(B)); B)
194-
195-
# fix method ambiguities for right division, from adjtrans.jl:
196-
/(u::AdjointAbsVec, A::UpperHessenberg) = adjoint(adjoint(A) \ u.parent)
197-
/(u::TransposeAbsVec, A::UpperHessenberg) = transpose(transpose(A) \ u.parent)
198-
/(u::AdjointAbsVec, A::Adjoint{<:Any,<:UpperHessenberg}) = adjoint(adjoint(A) \ u.parent)
199-
/(u::TransposeAbsVec, A::Transpose{<:Any,<:UpperHessenberg}) = transpose(transpose(A) \ u.parent)
200-
/(u::AdjointAbsVec, A::Transpose{<:Any,<:UpperHessenberg}) = adjoint(conj(A.parent) \ u.parent) # technically should be adjoint(copy(adjoint(copy(A))) \ u.parent)
201-
/(u::TransposeAbsVec, A::Adjoint{<:Any,<:UpperHessenberg}) = transpose(conj(A.parent) \ u.parent)
202-
203180
# Solving (H+µI)x = b: we can do this in O(m²) time and O(m) memory
204181
# (in-place in x) by the RQ algorithm from:
205182
#

test/hessenberg.jl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,6 @@ let n = 10
6464
H = UpperHessenberg(Areal)
6565
@test Array(Hc + H) == Array(Hc) + Array(H)
6666
@test Array(Hc - H) == Array(Hc) - Array(H)
67-
@testset "ldiv and rdiv" begin
68-
for b in (b_, B_), H in (H, Hc, H', Hc', transpose(Hc))
69-
@test H * (H \ b) b
70-
@test (b' / H) * H (Matrix(b') / H) * H b'
71-
@test (transpose(b) / H) * H (Matrix(transpose(b)) / H) * H transpose(b)
72-
end
73-
end
7467
@testset "Preserve UpperHessenberg shape (issue #39388)" begin
7568
H = UpperHessenberg(Areal)
7669
A = rand(n,n)

0 commit comments

Comments
 (0)