use === for comparison to nothing and Symbols (JuliaLang/julia#33764)

Author: JeffBezanson

src/cluster.jl

@@ -146,7 +146,7 @@ end
 function check_worker_state(w::Worker)
     if w.state == W_CREATED
         if !isclusterlazy()
-            if PGRP.topology == :all_to_all
+            if PGRP.topology === :all_to_all
                 # Since higher pids connect with lower pids, the remote worker
                 # may not have connected to us yet. Wait for some time.
                 wait_for_conn(w)
@@ -448,7 +448,7 @@ function addprocs_locked(manager::ClusterManager; kwargs...)
     params = merge(default_addprocs_params(), AnyDict(kwargs))
     topology(Symbol(params[:topology]))
 
-    if PGRP.topology != :all_to_all
+    if PGRP.topology !== :all_to_all
         params[:lazy] = false
     end
 
@@ -616,7 +616,7 @@ function create_worker(manager, wconfig)
     # - On master, receiving a JoinCompleteMsg triggers rr_ntfy_join (signifies that worker setup is complete)
 
     join_list = []
-    if PGRP.topology == :all_to_all
+    if PGRP.topology === :all_to_all
         # need to wait for lower worker pids to have completed connecting, since the numerical value
         # of pids is relevant to the connection process, i.e., higher pids connect to lower pids and they
         # require the value of config.connect_at which is set only upon connection completion
@@ -627,7 +627,7 @@ function create_worker(manager, wconfig)
             end
         end
 
-    elseif PGRP.topology == :custom
+    elseif PGRP.topology === :custom
         # wait for requested workers to be up before connecting to them.
         filterfunc(x) = (x.id != 1) && isdefined(x, :config) &&
             (notnothing(x.config.ident) in something(wconfig.connect_idents, []))
@@ -832,7 +832,7 @@ julia> workers()
 ```
 """
 function nprocs()
-    if myid() == 1 || (PGRP.topology == :all_to_all && !isclusterlazy())
+    if myid() == 1 || (PGRP.topology === :all_to_all && !isclusterlazy())
         n = length(PGRP.workers)
         # filter out workers in the process of being setup/shutdown.
         for jw in PGRP.workers
@@ -885,7 +885,7 @@ julia> procs()
 ```
 """
 function procs()
-    if myid() == 1 || (PGRP.topology == :all_to_all  && !isclusterlazy())
+    if myid() == 1 || (PGRP.topology === :all_to_all  && !isclusterlazy())
         # filter out workers in the process of being setup/shutdown.
         return Int[x.id for x in PGRP.workers if isa(x, LocalProcess) || (x.state == W_CONNECTED)]
     else
@@ -894,7 +894,7 @@ function procs()
 end
 
 function id_in_procs(id)  # faster version of `id in procs()`
-    if myid() == 1 || (PGRP.topology == :all_to_all  && !isclusterlazy())
+    if myid() == 1 || (PGRP.topology === :all_to_all  && !isclusterlazy())
         for x in PGRP.workers
             if (x.id::Int) == id && (isa(x, LocalProcess) || (x::Worker).state == W_CONNECTED)
                 return true
@@ -1120,7 +1120,7 @@ function deregister_worker(pg, pid)
         if myid() == 1 && (myrole() === :master) && isdefined(w, :config)
             # Notify the cluster manager of this workers death
             manage(w.manager, w.id, w.config, :deregister)
-            if PGRP.topology != :all_to_all || isclusterlazy()
+            if PGRP.topology !== :all_to_all || isclusterlazy()
                 for rpid in workers()
                     try
                         remote_do(deregister_worker, rpid, pid)

src/managers.jl

@@ -226,7 +226,7 @@ end
 
 
 function manage(manager::SSHManager, id::Integer, config::WorkerConfig, op::Symbol)
-    if op == :interrupt
+    if op === :interrupt
         ospid = config.ospid
         if ospid !== nothing
             host = notnothing(config.host)
@@ -340,7 +340,7 @@ function launch(manager::LocalManager, params::Dict, launched::Array, c::Conditi
 end
 
 function manage(manager::LocalManager, id::Integer, config::WorkerConfig, op::Symbol)
-    if op == :interrupt
+    if op === :interrupt
         kill(config.process, 2)
     end
 end