Handle non-integer pointer types. (#396)

Julia 1.12 will change how these are emitted.

Author: maleadt

.github/workflows/ci.yml

@@ -112,7 +112,7 @@ jobs:
 
   # fetching builds from Buildkite
   assert_test:
-    name: Julia-master ${{ matrix.build }} ${{ matrix.llvm_args }}
+    name: Julia ${{ matrix.branch }} ${{ matrix.llvm_args }} - ${{ matrix.build }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -121,14 +121,12 @@ jobs:
         arch: [x64]
         llvm_args: ['', '--opaque-pointers']
         include:
-          - version: '1.11'
+          - branch: 'release-1.11'
             pipeline: 'julia-release-1-dot-11'
             build: 'x86_64-linux-gnuassert'
-            branch: 'release-1.11'
-          #- version: 'master'
-          #  pipeline: 'julia-master'
-          #  build: 'x86_64-linux-gnuassert'
-          #  branch: 'master'
+          - branch: 'master'
+            pipeline: 'julia-master'
+            build: 'x86_64-linux-gnuassert'
     steps:
       - uses: actions/checkout@v4
         with:

src/interop/pointer.jl

@@ -227,18 +227,20 @@ end
                         bitcast!(builder, arg, actual_typ)
                     end
                 elseif argtyp <: Ptr
-                    # passed as i64
                     T = eltype(argtyp)
                     actual_typ = LLVM.PointerType(convert(LLVMType, T))
                     actual_arg = if const_arg == C_NULL
                         LLVM.PointerNull(actual_typ)
                     elseif const_arg !== nothing
                         intptr = LLVM.ConstantInt(LLVM.Int64Type(), Int(const_arg))
                         const_inttoptr(intptr, actual_typ)
+                    elseif value_type(arg) isa LLVM.PointerType
+                        # passed as i8* or ptr
+                        bitcast!(builder, arg, actual_typ)
                     else
+                        # passed as i64
                         inttoptr!(builder, arg, actual_typ)
                     end
-                    actual_arg = inttoptr!(builder, arg, actual_typ)
                 elseif argtyp <: Bool
                     # passed as i8
                     T = eltype(argtyp)
@@ -287,7 +289,11 @@ end
                 rv = if rettyp <: LLVMPtr
                     bitcast!(builder, rv, T_ret)
                 elseif rettyp <: Ptr
-                    ptrtoint!(builder, rv, T_ret)
+                    if T_ret isa LLVM.PointerType
+                        bitcast!(builder, rv, T_ret)
+                    else
+                        ptrtoint!(builder, rv, T_ret)
+                    end
                 elseif rettyp <: Bool
                     zext!(builder, rv, T_ret)
                 else
@@ -314,6 +320,11 @@ Perform a `ccall` while more accurately preserving argument types like LLVM expe
 
 These features can be useful to call LLVM intrinsics, which may expect a specific set of
 argument types.
+
+!!! note
+
+    This macro is not needed anymore on Julia 1.12, where the `llvmcall` ABI has been
+    extended to preserve argument types more accurately.
 """
 macro typed_ccall(intrinsic, cc, rettyp, argtyps, args...)
     # destructure and validate the arguments