🧹 Move complement to ColorVectorSpace

`complement` is such a basic operation that we moved to lower-level package
ColorVectorSpace in PR
JuliaGraphics/ColorVectorSpace.jl#144

This requires ColorVectorSpace v0.9.2. Since we indirectly get CVS via
ImageCore, we need to set a compatible ImageCore version that requires CVS >=
v0.9.2. For this reason, this commit sets ImageCore compatibility to v0.9.3 so
that we get CVS at least v0.9.7

Author: johnnychen94

Project.toml

@@ -35,7 +35,7 @@ FileIO = "1"
 Graphics = "0.4, 1.0"
 ImageAxes = "0.6"
 ImageContrastAdjustment = "0.3.3"
-ImageCore = "0.9"
+ImageCore = "0.9.3"
 ImageDistances = "0.2.5"
 ImageFiltering = "0.6.3"
 ImageIO = "0.0.1, 0.3, 0.4, 0.5"

src/Images.jl

@@ -107,7 +107,6 @@ include("compat.jl")
 include("misc.jl")
 include("labeledarrays.jl")
 include("algorithms.jl")
-include("exposure.jl")
 include("deprecations.jl")
 include("corner.jl")
 include("edge.jl")
@@ -170,7 +169,6 @@ export
     yen_threshold,
 
     #Exposure
-    complement,
     imhist,
     histeq,
     adjust_gamma,

src/deprecations.jl

@@ -1068,3 +1068,11 @@ function shepp_logan(M,N; highContrast=true)
 end
 
 shepp_logan(N;highContrast=true) = shepp_logan(N,N;highContrast=highContrast)
+
+# `complement` is now moved to ColorVectorSpace but we still want to keep backward compatibility
+# until Images 1.0
+function ColorVectorSpace.complement(x::AbstractArray)
+    Base.depwarn("`complement(img)` is deprecated, please use the broadcasting version `complement.(img)`", :complement)
+    complement.(x)
+end
+

src/exposure.jl

@@ -67,14 +67,6 @@ using Test, Suppressor
 
     Random.seed!(1234)
 
-    @testset "Complement" begin
-        @test complement.([Gray(0.2)]) == [Gray(0.8)]
-        @test complement.([Gray{N0f8}(0.2)]) == [Gray{N0f8}(0.8)]
-        @test complement.([RGB(0,0.3,1)]) == [RGB(1,0.7,0)]
-        @test complement.([RGBA(0,0.3,1,0.7)]) == [RGBA(1.0,0.7,0.0,0.7)]
-        @test complement.([RGBA{N0f8}(0,0.6,1,0.7)]) == [RGBA{N0f8}(1.0,0.4,0.0,0.7)]
-    end
-
     @testset "Entropy" begin
         img = rand(1:10,10,10)
         img2 = rand(1:2,10,10)

test/algorithms.jl

@@ -0,0 +1,11 @@
+# When we deprecate old APIs, we copy the old tests here to make sure they still work
+
+@testset "deprecations" begin
+
+    @testset "Complement" begin
+        # deprecated (#690)
+        img = Gray{N0f16}.([0.01164 0.01118; 0.01036 0.01187])
+        @test all(complement(img) .== 1 .- img)
+    end
+
+end

test/deprecated.jl

@@ -514,13 +514,6 @@ eye(m,n) = Matrix{Float64}(I,m,n)
         @test imadjustintensity(img,[0.0103761, 0.0252166])[2,1] == 0.0
         @test eltype(imadjustintensity(img)) == Gray{N0f16}
 
-        img = Gray{N0f16}.([0.01164 0.01118; 0.01036 0.01187])
-        @test complement(Gray(0.5)) == Gray(0.5)
-        @test complement(Gray(0.2)) == Gray(0.8)
-        @test all(complement.(img) .== 1 .- img)
-        # deprecated (#690)
-        @test all(complement.(img) .== 1 .- img)
-
         hist = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
 
         clipped_hist = cliphist(hist, 2)

test/exposure.jl

@@ -0,0 +1,20 @@
+# These tests once lived in other files, but related functions are declared legacy or moved to
+# other packages. For regression test purpose, we still keep them here.
+
+@testset "legacy" begin
+
+    # Moved to ColorVectorSpace
+    @testset "Complement" begin
+        img = Gray{N0f16}.([0.01164 0.01118; 0.01036 0.01187])
+        @test complement(Gray(0.5)) == Gray(0.5)
+        @test complement(Gray(0.2)) == Gray(0.8)
+        @test all(complement.(img) .== 1 .- img)
+
+        @test complement.([Gray(0.2)]) == [Gray(0.8)]
+        @test complement.([Gray{N0f8}(0.2)]) == [Gray{N0f8}(0.8)]
+        @test complement.([RGB(0,0.3,1)]) == [RGB(1,0.7,0)]
+        @test complement.([RGBA(0,0.3,1,0.7)]) == [RGBA(1.0,0.7,0.0,0.7)]
+        @test complement.([RGBA{N0f8}(0,0.6,1,0.7)]) == [RGBA{N0f8}(1.0,0.4,0.0,0.7)]
+    end
+
+end

test/legacy.jl

@@ -8,6 +8,8 @@ include("algorithms.jl")
 include("edge.jl")
 include("corner.jl")
 include("writemime.jl")
-# include("deprecated.jl")
+
+@suppress_err include("legacy.jl")
+@suppress_err include("deprecated.jl")
 
 end