Skip to content

Commit 4b2d7ff

Browse files
authored
Fix transposed weights in get_weight (#40)
Solves #39
1 parent 0b99400 commit 4b2d7ff

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/abstractsimpleweightedgraph.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ weighttype(::AbstractSimpleWeightedGraph{T,U}) where {T} where {U} = U
3131
3232
Retrieve the weight of edge `(u, v)`.
3333
"""
34-
get_weight(g::AbstractSimpleWeightedGraph, u::Integer, v::Integer) = weights(g)[v, u]
34+
get_weight(g::AbstractSimpleWeightedGraph, u::Integer, v::Integer) = weights(g)[u, v]
3535

3636
## Vertices
3737

src/simpleweighteddigraph.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ Base.:(==)(g::SimpleWeightedDiGraph, h::SimpleWeightedDiGraph) = g.weights == h.
221221
Graphs.is_directed(::Type{<:SimpleWeightedDiGraph}) = true
222222

223223
"""
224-
g[e, :weight]
224+
g[e, Val(:weight)]
225225
226226
Return the weight of edge `e`.
227227
"""
@@ -230,7 +230,7 @@ function Base.getindex(g::SimpleWeightedDiGraph, e::AbstractEdge, ::Val{:weight}
230230
end
231231

232232
"""
233-
g[i, j, :weight]
233+
g[i, j, Val(:weight)]
234234
235235
Return the weight of edge `(i, j)`.
236236
"""

test/simpleweightedgraph.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,13 @@ using SimpleWeightedGraphs
292292
add_edge!(g, 1, 2, 5.0)
293293

294294
@test g[1, 2, Val{:weight}()] 5
295+
@test get_weight(g, 1, 2) 5
295296
if is_directed(G)
296297
@test g[2, 1, Val{:weight}()] 0
298+
@test get_weight(g, 2, 1) 0
297299
else
298300
@test g[2, 1, Val{:weight}()] 5
301+
@test get_weight(g, 2, 1) 5
299302
end
300303
m = adjacency_matrix(g)
301304
@test g[2, 1, Val{:weight}()] g.weights[1, 2]

0 commit comments

Comments
 (0)