Merge pull request #66 from JuliaGeometry/sd/fix_uvnormalmesh

fix uv_normalmesh for 2d

Author: SimonDanisch

src/interfaces.jl

@@ -18,7 +18,7 @@ function faces(f::AbstractVector{<:AbstractFace})
     return f
 end
 
-function normals(primitive, nvertices=nothing)
+function normals(primitive, nvertices=nothing; kw...)
     # doesn't have any specific algorithm to generate normals
     # so will be generated from faces + positions
     # which we indicate by returning nothing!
@@ -27,7 +27,7 @@ function normals(primitive, nvertices=nothing)
     return nothing
 end
 
-function faces(primitive, nvertices=nothing)
+function faces(primitive, nvertices=nothing; kw...)
     # doesn't have any specific algorithm to generate faces
     # so will try to triangulate the coordinates!
     return nothing

test/runtests.jl

@@ -362,7 +362,11 @@ end
     @test coordinates(m) === points
 end
 
-
+@testset "convert mesh + meta" begin
+    m = uv_normal_mesh(Circle(Point2f0(0), 1f0))
+    # for 2D primitives we dont actually calculate normals
+    @test !hasproperty(m, :normals)
+end
 
 @testset "convert mesh + meta" begin
     m = uv_normal_mesh(FRect3D(Vec3f0(-1), Vec3f0(1, 2, 3)))