Skip to content

Queue operations on the current device, not the one owning the array. #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 13, 2024

When using host or shared buffer types, there isn't a clear owner, so let's use the CUDA semantics of executing on the currently-active device. This makes it possible to properly synchronize before copying host memory, which is needed for correctness.

When using host or shared buffer types, there isn't a clear owner,
so let's use the CUDA semantics of executing on the currently-active
device.
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 90.54054% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.22%. Comparing base (260a4dd) to head (ec6b79d).

Files Patch % Lines
lib/mkl/wrappers_blas.jl 90.47% 4 Missing ⚠️
lib/mkl/wrappers_lapack.jl 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   81.25%   81.22%   -0.03%     
==========================================
  Files          45       45              
  Lines        2571     2573       +2     
==========================================
+ Hits         2089     2090       +1     
- Misses        482      483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit b1ba771 into master Aug 13, 2024
1 check passed
@maleadt maleadt deleted the tb/active_device branch August 13, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant