Skip to content

Commit 7229af4

Browse files
authored
Apply suggestions from code review
1 parent 8ec2e28 commit 7229af4

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/cache.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const specialization_counter = Ref{UInt}(0)
6262
return new_ci
6363
end
6464

65-
const disk_cache = parse(Bool, @load_preference("disk_cache", "false"))
65+
const disk_cache = @load_preference("disk_cache", false)
6666
const cache_key = @load_preference("cache_key", "")
6767

6868
"""
@@ -85,7 +85,7 @@ end
8585
8686
If you are deploying an application it is recommended that you use your
8787
application name and version as a cache key. To minimize the risk of
88-
encountering spurios cache hits.
88+
encountering spurious cache hits.
8989
"""
9090
function set_cache_key(key)
9191
@set_preferences!("cache_key"=>key)

test/CacheEnv/LocalPreferences.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[GPUCompiler]
2-
disk_cache = "true"
3-
cache_key = "test"
2+
disk_cache = true
3+
cache_key = "test"

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ haskey(ENV, "CI") && GPUCompiler.timings()
3636
cmd = `$cmd --project=$(unsafe_string(Base.JLOptions().project))`
3737
end
3838

39-
withenv("JULIA_LOAD_PATH" => "$(get(ENV, "JULIA_LOAD_PATH", "")):$(joinpath(@__DIR__, "CacheEnv"))" do
39+
withenv("JULIA_LOAD_PATH" => "$(get(ENV, "JULIA_LOAD_PATH", "")):$(joinpath(@__DIR__, "CacheEnv"))") do
4040
@test success(pipeline(`$cmd cache.jl true`, stderr=stderr, stdout=stdout))
4141
@test success(pipeline(`$cmd cache.jl false`, stderr=stderr, stdout=stdout))
4242
end

0 commit comments

Comments
 (0)