Fix righthand side diagonal multiplication (#441)

Author: GVigne

src/host/linalg.jl

@@ -212,7 +212,7 @@ else
         m′, n′ = size(B, 1), size(B, 2)
         n == d || throw(DimensionMismatch("left hand side has $n columns but D is $d by $d"))
         (m, n) == (m′, n′) || throw(DimensionMismatch("expect output to be $m by $n, but got $m′ by $n′"))
-        @. B' = dd * A'
+        B .= A .* transpose(dd)
 
         B
     end
@@ -228,7 +228,7 @@ else
         m′, n′ = size(B, 1), size(B, 2)
         n == d || throw(DimensionMismatch("left hand side has $n columns but D is $d by $d"))
         (m, n) == (m′, n′) || throw(DimensionMismatch("expect output to be $m by $n, but got $m′ by $n′"))
-        @. B' = α * dd * A' + β * B'
+        B .= α * A .* transpose(dd) + β * B
 
         B
     end

test/testsuite/linalg.jl

@@ -154,26 +154,28 @@
         end
 
         @testset "mul! + Diagonal" begin
-            n = 128
-            d = AT(rand(Float32, n))
-            D = Diagonal(d)
-            B = AT(rand(Float32, n, n))
-            X = AT(zeros(Float32, n, n))
-            Y = zeros(Float32, n, n)
-            α = rand(Float32)
-            β = rand(Float32)
-            mul!(X, D, B)
-            mul!(Y, Diagonal(collect(d)), collect(B))
-            @test collect(X) ≈ Y
-            mul!(X, D, B, α, β)
-            mul!(Y, Diagonal(collect(d)), collect(B), α, β)
-            @test collect(X) ≈ Y
-            mul!(X, B, D)
-            mul!(Y, collect(B), Diagonal(collect(d)))
-            @test collect(X) ≈ Y
-            mul!(X, B, D, α, β)
-            mul!(Y, collect(B), Diagonal(collect(d)), α, β)
-            @test collect(X) ≈ Y
+            for elty in (Float32, ComplexF32)
+                n = 128
+                d = AT(rand(elty, n))
+                D = Diagonal(d)
+                B = AT(rand(elty, n, n))
+                X = AT(zeros(elty, n, n))
+                Y = zeros(elty, n, n)
+                α = rand(elty)
+                β = rand(elty)
+                mul!(X, D, B)
+                mul!(Y, Diagonal(collect(d)), collect(B))
+                @test collect(X) ≈ Y
+                mul!(X, D, B, α, β)
+                mul!(Y, Diagonal(collect(d)), collect(B), α, β)
+                @test collect(X) ≈ Y
+                mul!(X, B, D)
+                mul!(Y, collect(B), Diagonal(collect(d)))
+                @test collect(X) ≈ Y
+                mul!(X, B, D, α, β)
+                mul!(Y, collect(B), Diagonal(collect(d)), α, β)
+                @test collect(X) ≈ Y
+            end
         end
 
         @testset "ldiv! + Diagonal" begin