Specialize Base.copy! for AbstractGPUArrays (#414)

Author: vpuri3

.gitignore

@@ -1,3 +1,8 @@
 *.jl.cov
 *.jl.*.cov
 *.jl.mem
+
+# editor generated files
+.*.swp
+.*.swo
+*~

src/host/abstractarray.jl

@@ -42,6 +42,12 @@ Base.collect(X::AnyGPUArray) = collect_to_cpu(X)
 
 # memory copying
 
+function Base.copy!(dst::AbstractGPUVector, src::AbstractGPUVector)
+    axes(dst) == axes(src) || throw(ArgumentError(
+    "arrays must have the same axes for `copy!`. consider using `copyto!` instead"))
+    copyto!(dst, src)
+end
+
 ## basic linear copies of identically-typed memory
 
 # expects the GPU array type to have linear `copyto!` methods (i.e. accepting an integer

test/testsuite/base.jl

@@ -26,6 +26,19 @@ function ntuple_closure(ctx, result, ::Val{N}, testval) where N
 end
 
 @testsuite "base" (AT, eltypes)->begin
+    @testset "copy!" begin
+        for (dst, src,) in (
+                            (rand(Float32, (10,)),   rand(Float32, (10,))),   # vectors
+                            (rand(Float32, (10,20)), rand(Float32, (10,20))), # multidim
+                            )
+            dst = AT(dst)
+            src = AT(src)
+            
+            copy!(dst, src)
+            @test dst == src
+        end
+    end
+
     @testset "copyto!" begin
         x = fill(0f0, (10, 10))
         y = rand(Float32, (20, 10))