[CUSOLVER] Add more tests for the dense SVD

Author: amontoison

lib/cusolver/dense.jl

@@ -389,31 +389,30 @@ for (bname, fname, elty, relty) in ((:cusolverDnSgesvd_bufferSize, :cusolverDnSg
                         A::StridedCuMatrix{$elty})
             m, n = size(A)
             (m < n) && throw(ArgumentError("CUSOLVER's gesvd requires m ≥ n"))
+            k = min(m, n)
             lda = max(1, stride(A, 2))
 
             U = if jobu === 'A'
                 similar(A, $elty, (m, m))
             elseif jobu == 'S' || jobu === 'O'
-                similar(A, $elty, (m, min(m, n)))
+                similar(A, $elty, (m, k))
             elseif jobu === 'N'
                 CU_NULL
             else
                 error("jobu must be one of 'A', 'S', 'O', or 'N'")
             end
-            ldu     = U == CU_NULL ? 1 : max(1, stride(U, 2))
-
-            S       = similar(A, $relty, min(m, n))
-
+            ldu = U == CU_NULL ? 1 : max(1, stride(U, 2))
+            S = similar(A, $relty, k)
             Vt = if jobvt === 'A'
                 similar(A, $elty, (n, n))
             elseif jobvt === 'S' || jobvt === 'O'
-                similar(A, $elty, (min(m, n), n))
+                similar(A, $elty, k, n))
             elseif jobvt === 'N'
                 CU_NULL
             else
                 error("jobvt must be one of 'A', 'S', 'O', or 'N'")
             end
-            ldvt    = Vt == CU_NULL ? 1 : max(1, stride(Vt, 2))
+            ldvt = Vt == CU_NULL ? 1 : max(1, stride(Vt, 2))
             dh = dense_handle()
 
             function bufferSize()

test/libraries/cusolver/dense.jl

@@ -194,6 +194,21 @@ k = 1
         @test p ≈ h_TAUP
     end
 
+    @testset "gesvd!" begin
+        A = rand(elty,m,n)
+        d_A = CuMatrix(A)
+        U, Σ, Vt = CUSOLVER.gesvd!('A', 'A', d_A)
+        @test A ≈ collect(U[:,1:n] * Diagonal(Σ) * Vt)
+
+        for jobu in ('A', 'S', 'N', 'O')
+            for jobvt in ('A', 'S', 'N', 'O')
+                d_A = CuMatrix(A)
+                U2, Σ2, Vt2 = CUSOLVER.gesvd!(jobu, jobvt, d_A)
+                @test Σ ≈ Σ2
+            end
+        end
+    end
+
     @testset "syevd!" begin
         A              = rand(elty,m,m)
         A             += A'

test/libraries/cusolver/dense_generic.jl

@@ -149,6 +149,14 @@ p = 5
         d_A = CuMatrix(A)
         U, Σ, Vt = CUSOLVER.Xgesvd!('A', 'A', d_A)
         @test A ≈ collect(U[:,1:n] * Diagonal(Σ) * Vt)
+
+        for jobu in ('A', 'S', 'N', 'O')
+            for jobvt in ('A', 'S', 'N', 'O')
+                d_A = CuMatrix(A)
+                U2, Σ2, Vt2 = CUSOLVER.Xgesvd!(jobu, jobvt, d_A)
+                @test Σ ≈ Σ2
+            end
+        end
     end
 
     @testset "gesvdp!" begin