Even MORE tests and cov for CUBLAS (#2670)

Author: kshyatt

lib/cublas/linalg.jl

@@ -38,6 +38,7 @@ function LinearAlgebra.dot(x::AnyCuArray{T1}, y::AnyCuArray{T2}) where {T1,T2}
 
     # custom kernel using simple linear indexing and atomic additions,
     # resulting in about 10% speed-up compared to a simple mapreduce.
+    # COV_EXCL_START
     function kernel(x, y, res::AbstractArray{T}, shuffle) where {T}
         local_val = zero(T)
 
@@ -56,6 +57,7 @@ function LinearAlgebra.dot(x::AnyCuArray{T1}, y::AnyCuArray{T2}) where {T1,T2}
 
         return
     end
+    # COV_EXCL_STOP
 
     dev = device()
     let T = promote_type(T1, T2)

test/libraries/cublas/extensions.jl

@@ -567,6 +567,8 @@ k = 13
             d_X = Diagonal(d_x)
             mul!(d_AX, d_A', d_X)
             Array(d_AX) ≈ A' * Diagonal(x)
+
+            @test Array(d_X) == Diagonal(Array(d_x))
         end
     end # extensions
 

test/libraries/cublas/level2.jl

@@ -458,7 +458,12 @@ k = 13
 
         @testset "lmul!(::UpperTriangular)" begin
             dy = copy(dx)
-            lmul!(UpperTriangular(dA), dy)
+            utdA = UpperTriangular(dA)
+            if VERSION >= v"1.11.2"
+                @test istriu(utdA)
+                @test !istril(utdA)
+            end
+            lmul!(utdA, dy)
             y = UpperTriangular(A) * x
             @test y ≈ Array(dy)
         end
@@ -476,7 +481,12 @@ k = 13
         end
         @testset "lmul!(::LowerTriangular)" begin
             dy = copy(dx)
-            lmul!(LowerTriangular(dA), dy)
+            ltdA = LowerTriangular(dA)
+            if VERSION >= v"1.11.2"
+                @test !istriu(ltdA)
+                @test istril(ltdA)
+            end
+            lmul!(ltdA, dy)
             y = LowerTriangular(A) * x
             @test y ≈ Array(dy)
         end

test/libraries/cublas/level3.jl

@@ -291,8 +291,14 @@ k = 13
             dB = CuArray(B)
 
             C = A / B
+            d_C = dA / dB
+            h_C = Array(d_C)
             rdiv!(dA, dB)
             @test C ≈ Array(dA)
+            @test C ≈ h_C
+
+            B_bad = Diagonal(rand(elty, m+1))
+            @test_throws DimensionMismatch("left hand side has $m columns but D is $(m+1) by $(m+1)") rdiv!(dA, B_bad)
         end
 
         @testset "geam!" begin