Skip to content

Commit 1a3669d

Browse files
authored
Try re-enabling the convolution tests (#2678)
* Try re-enabling the convolution tests * Remove extraneous lines
1 parent b1cabe8 commit 1a3669d

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

lib/cudnn/test/convolution.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ function convtest(;
134134
ay2 = act.(ay .+ beta * ay0)
135135
end
136136

137-
d = cudnnConvolutionDescriptor(convdims(padding,size(ax)),
138-
convdims(stride,size(ax)),
139-
convdims(dilation,size(ax)), mode,
137+
d = cudnnConvolutionDescriptor(convdims(padding,size(ax),1),
138+
convdims(stride,size(ax),1),
139+
convdims(dilation,size(ax),1), mode,
140140
cudnnDataType(dataType), mathType, reorderType,
141141
Cint(group))
142142
@test ay1 cudnnConvolutionForward(cw0, cx; bias, activation, mode, padding,

lib/cudnn/test/runtests.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ for entry in readdir(@__DIR__)
1414
endswith(entry, ".jl") || continue
1515
entry in ["runtests.jl"] && continue
1616

17-
# XXX: disabled due to sporadic CI issue (JuliaGPU/CUDA.jl#/725)
18-
entry == "convolution.jl" && continue
19-
2017
# XXX: disabled due to crash on CUDA 11.4 (JuliaGPU/CUDA.jl#2498)
2118
if CUDA.runtime_version() < v"12" && entry == "multiheadattn.jl"
2219
continue

0 commit comments

Comments
 (0)