Merge pull request #256 from avik-pal/ap/vecjac

VecJac also has inplace definitions

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "SparseDiffTools"
 uuid = "47a9eef4-7e08-11e9-0b38-333d64bd3804"
 authors = ["Pankaj Mishra <pankajmishra1511@gmail.com>", "Chris Rackauckas <contact@chrisrackauckas.com>"]
-version = "2.5.0"
+version = "2.5.1"
 
 [deps]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"

src/differentiation/vecjac_products.jl

@@ -58,7 +58,9 @@ function VecJac(f, u::AbstractArray, p = nothing, t = nothing;
         throw(ArgumentError(msg))
     end
 
-    return FunctionOperator(L, u, u; isinplace = IIP, outofplace = OOP,
+    # NOTE: The operator returned has both in-place and out-of-place definitions and
+    #       doesn't follow the convention of `f`
+    return FunctionOperator(L, u, u; isinplace = true, outofplace = OOP,
         p, t, islinear = true, accepted_kwargs = (:VJP_input,), kwargs...)
 end