Skip to content

Make replace boolean check_inferred with something that allows configuable small unions #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oxinabox opened this issue May 19, 2023 · 0 comments
Open

Make replace boolean check_inferred with something that allows configuable small unions #283

oxinabox opened this issue May 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@oxinabox
Copy link
Member

occured to me during JuliaDiff/ChainRules.jl#717
that there are like 3 states we really care about:

  1. Doesn't infer at all, so infers to Any or some UnionAll or abstract type
  2. Infers down to a small union of <4 types, so the small union optimization kicks in
  3. Infers down to a single concrete type

The current check_inferred boolean doesn't allow us to distinguish case 1 from case 2.
@oxinabox oxinabox added the enhancement New feature or request label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oxinabox