Skip to content

Commit d9821a8

Browse files
Remove major invalidations from ==
See #523 . Seems to only be used for tests according to the PR but it's a major compile time problem, so it doesn't make sense to keep them. This can be marked breaking if it breaks downstream, but it's rather easy to update downstream AD packages for this so the value proposition is pretty clear.
1 parent a9840b4 commit d9821a8

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

src/tangent_types/thunks.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ end
2525
end
2626

2727
Base.:(==)(a::AbstractThunk, b::AbstractThunk) = unthunk(a) == unthunk(b)
28-
Base.:(==)(a::AbstractThunk, b) = unthunk(a) == b
29-
Base.:(==)(a, b::AbstractThunk) = a == unthunk(b)
3028

3129
Base.:(-)(a::AbstractThunk) = -unthunk(a)
3230
Base.:(-)(a::AbstractThunk, b) = unthunk(a) - b

test/tangent_types/thunks.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@testset "==" begin
77
@test @thunk(3.2) == InplaceableThunk(x -> x + 3.2, @thunk(3.2))
8-
@test @thunk(3.2) == 3.2
98
@test 3.2 == InplaceableThunk(x -> x + 3.2, @thunk(3.2))
109
end
1110

0 commit comments

Comments
 (0)