Skip to content

Commit ae343a5

Browse files
Update docs/src/design/changing_the_primal.md
Co-authored-by: Nick Robinson <npr251@gmail.com> Update docs/src/design/changing_the_primal.md
1 parent e91f8d1 commit ae343a5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/src/design/changing_the_primal.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ Not to mention these are fairly simple example, the `sin` and `σ` functions hav
186186
Furthermore, we often don't even use all of the arguments to `pullback_at`.
187187
The new code for pulling back `sin` — which uses `sincos` and `intermediates` — no longer needs `x`, and it never needed `y` (though sigmoid `σ` does).
188188
And storing all these things on the tape — inputs, outputs, sensitivities, intermediates — is using up extra memory.
189-
What if we generalized the idea of the `intermediate` named tuple, and had a struct that just held anything we might want put on the tape.
189+
What if we generalized the idea of the `intermediate` named tuple, and had `augmented_primal` return a struct that just held anything we might want put on the tape.
190190
```julia
191191
struct PullbackMemory{P, S}
192192
primal_function::P
@@ -468,7 +468,7 @@ In this computation the factorization of the original `A` can reused.
468468
Doing so can give a 4x speed-up.
469469

470470
We don't have this in ChainRules.jl yet, because Julia is missing some definitions of `adjoint` of factorizations ([JuliaLang/julia#38293](https://github.com/JuliaLang/julia/issues/38293)).
471-
I have been promised them for Julia v1.7 though.
471+
We have been promised them for Julia v1.7 though.
472472
You can see what the code would look like in [PR #302](https://github.com/JuliaDiff/ChainRules.jl/pull/302).
473473

474474
## Conclusion

0 commit comments

Comments
 (0)