formatting

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: oxinabox

src/tangent_types/abstract_zero.jl

@@ -123,7 +123,6 @@ zero_tangent(x::Number) = zero(x)
         )
         Expr(:kw, fname, fval)
     end
-    
     return if has_mutable_tangent(primal)
         any_mask = map(fieldnames(primal), fieldtypes(primal)) do fname, ftype
             # If it is is unassigned, or if it doesn't have a concrete type, let it take any value for its tangent
@@ -132,11 +131,11 @@ zero_tangent(x::Number) = zero(x)
         end
         :($MutableTangent{$primal}(
             $(Expr(:tuple, Expr(:parameters, any_mask...))),
-            $(Expr(:tuple, Expr(:parameters, zfield_exprs...)))
+            $(Expr(:tuple, Expr(:parameters, zfield_exprs...))),
         ))
     else
         :($Tangent{$primal}($(Expr(:parameters, zfield_exprs...))))
-    end    
+    end
 end
 
 zero_tangent(primal::Tuple) = Tangent{typeof(primal)}(map(zero_tangent, primal)...)
@@ -160,5 +159,7 @@ end
 # Sad heauristic methods we need because of unassigned values
 guess_zero_tangent_type(::Type{T}) where {T<:Number} = T
 guess_zero_tangent_type(::Type{T}) where {T<:Integer} = typeof(float(zero(T)))
-guess_zero_tangent_type(::Type{<:Array{T,N}}) where {T,N} = return Array{guess_zero_tangent_type(T),N}
-guess_zero_tangent_type(T::Type)=  Any
+function guess_zero_tangent_type(::Type{<:Array{T,N}}) where {T,N}
+    return Array{guess_zero_tangent_type(T),N}
+end
+guess_zero_tangent_type(T::Type) = Any

test/tangent_types/abstract_zero.jl

@@ -173,15 +173,14 @@ end
     @test zero_tangent(MutDemo(1.5)) isa MutableTangent{MutDemo}
     @test iszero(zero_tangent(MutDemo(1.5)))
 
-    @test zero_tangent((; a=1)) isa Tangent{typeof((;a=1))}
+    @test zero_tangent((; a=1)) isa Tangent{typeof((; a = 1))}
     @test zero_tangent(Demo(1.2)) isa Tangent{Demo}
     @test zero_tangent(Demo(1.2)).x === 0.0
 
     @test zero_tangent([1.0, 2.0]) == [0.0, 0.0]
     @test zero_tangent([[1.0, 2.0], [3.0]]) == [[0.0, 0.0], [0.0]]
 
     @test zero_tangent((1.0, 2.0)) == Tangent{Tuple{Float64,Float64}}(0.0, 0.0)
-    
     @testset "undef elements Vector" begin
         x = Vector{Vector{Float64}}(undef, 3)
         x[2] = [1.0, 2.0]
@@ -234,24 +233,24 @@ end
 
         mutable struct MyStructWithNonConcreteFields
             x::Any
-            y::Union{Float64, Vector{Float64}}
+            y::Union{Float64,Vector{Float64}}
             z::AbstractVector
         end
         d = zero_tangent(MyStructWithNonConcreteFields(1.0, 2.0, [3.0]))
         @test iszero(d.x)
-        d.x = Tangent{Base.RefValue{Float64}}(x=1.5)
-        @test d.x == Tangent{Base.RefValue{Float64}}(x=1.5)  #should be assignable
-        d.x=2.4
+        d.x = Tangent{Base.RefValue{Float64}}(; x=1.5)
+        @test d.x == Tangent{Base.RefValue{Float64}}(; x=1.5)  #should be assignable
+        d.x = 2.4
         @test d.x == 2.4  #should be assignable
         @test iszero(d.y)
-        d.y=2.4
+        d.y = 2.4
         @test d.y == 2.4  #should be assignable
-        d.y=[2.4]
+        d.y = [2.4]
         @test d.y == [2.4]  #should be assignable
         @test iszero(d.z)
         d.z = [1.0, 2.0]
         @test d.z == [1.0, 2.0]
-        d.z = @view [2.0,3.0,4.0][1:2]
+        d.z = @view [2.0, 3.0, 4.0][1:2]
         @test d.z == [2.0, 3.0]
         @test d.z isa SubArray
     end

test/tangent_types/structural_tangent.jl

@@ -457,40 +457,40 @@ end
     end
 
     @testset "== and hash" begin
-        @test MutableTangent{MDemo}(; x=1f0) == MutableTangent{MDemo}(; x=1.0)
-        @test MutableTangent{MDemo}(; x=1.0) == MutableTangent{MDemo}(; x=1f0)
+        @test MutableTangent{MDemo}(; x=1.0f0) == MutableTangent{MDemo}(; x=1.0)
+        @test MutableTangent{MDemo}(; x=1.0) == MutableTangent{MDemo}(; x=1.0f0)
         @test MutableTangent{MDemo}(; x=2.0) != MutableTangent{MDemo}(; x=1.0)
         @test MutableTangent{MDemo}(; x=1.0) != MutableTangent{MDemo}(; x=2.0)
 
         nt = (; x=1.0)
         @test MutableTangent{typeof(nt)}(nt) != MutableTangent{MDemo}(; x=1.0)
 
-        @test hash(MutableTangent{MDemo}(; x=1f0)) == hash(MutableTangent{MDemo}(; x=1.0))
+        @test hash(MutableTangent{MDemo}(; x=1.0f0)) == hash(MutableTangent{MDemo}(; x=1.0))
     end
 
     @testset "Mutation" begin
-        v = MutableTangent{MFoo}(x=1.5, y=2.4)
+        v = MutableTangent{MFoo}(; x=1.5, y=2.4)
         v.x = 1.6
-        @test v == MutableTangent{MFoo}(x=1.6, y=2.4)
+        @test v == MutableTangent{MFoo}(; x=1.6, y=2.4)
         v.y = [1.0, 2.0]  # change type, because primal can change type
-        @test v == MutableTangent{MFoo}(x=1.6, y=[1.0, 2.0])
+        @test v == MutableTangent{MFoo}(; x=1.6, y=[1.0, 2.0])
     end
 end
 
 @testset "map" begin
     @testset "Tangent" begin
-        ∂foo = Tangent{Foo}(x=1.5, y=2.4)
-        @test map(v->2*v, ∂foo) == Tangent{Foo}(x=3.0, y=4.8)
+        ∂foo = Tangent{Foo}(; x=1.5, y=2.4)
+        @test map(v -> 2 * v, ∂foo) == Tangent{Foo}(; x=3.0, y=4.8)
 
-        ∂foo = Tangent{Foo}(x=1.5)
-        @test map(v->2*v, ∂foo) == Tangent{Foo}(x=3.0)
+        ∂foo = Tangent{Foo}(; x=1.5)
+        @test map(v -> 2 * v, ∂foo) == Tangent{Foo}(; x=3.0)
     end
     @testset "MutableTangent" begin
-        ∂foo = MutableTangent{MFoo}(x=1.5, y=2.4)
-        ∂foo2 = map(v->2*v, ∂foo)
-        @test ∂foo2 == MutableTangent{MFoo}(x=3.0, y=4.8)
+        ∂foo = MutableTangent{MFoo}(; x=1.5, y=2.4)
+        ∂foo2 = map(v -> 2 * v, ∂foo)
+        @test ∂foo2 == MutableTangent{MFoo}(; x=3.0, y=4.8)
         # Check can still be mutated to new typ
-        ∂foo2.y=[1.0, 2.0]
-        @test ∂foo2 == MutableTangent{MFoo}(x=3.0, y=[1.0, 2.0])
+        ∂foo2.y = [1.0, 2.0]
+        @test ∂foo2 == MutableTangent{MFoo}(; x=3.0, y=[1.0, 2.0])
     end
 end