Skip to content

Commit 369b273

Browse files
oxinaboxmzgubic
andcommitted
Apply suggestions from code review
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
1 parent c190bdf commit 369b273

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/src/nondiff_points.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ We will justify this further below, but first let us discuss what it means.
3333

3434
## What is the sub/super-differential?
3535

36-
The subderivative is defined only for locally convex functions, where-as the super-deriviative is fined only for locally concave functions.
37-
For our purpose we, basically never care which we are working with and so write sub/super-derivative.
36+
The subderivative is defined only for locally convex functions, whereas the super-derivative is defined only for locally concave functions.
37+
For our purpose we basically never care which we are working with and so write sub/super-derivative.
3838

3939
For a function $f$ at some point $x_0$ a sub/super-derivative is a real number $c$ such that there exists a open ball $\mathcal{B} \subset \mathrm{dom}(f)$ containing $x_0$,
4040
and for all points $z \in \mathcal{B}$ the following holds:
@@ -126,7 +126,7 @@ It will agree with either the forwards or reverse finite differencing results.
126126
Practically speaking, people are generally using AD to perform some gradient descent like optimization procedure.
127127
`NaN` and `Inf` do not generally take us to nice places.
128128
Erroring can be worse, especially if it is a local minima -- the optimization fully converges to that minima and then throws an error rather than reporting the result.
129-
If the primal function takes a non-finite value or errors on one side, then we are in the case that we are at a boundry of the domain.
129+
If the primal function takes a non-finite value or errors on one side, then we are in the case that we are at a boundary of the domain.
130130
Which means we are free to chose *any* value.
131131
In particular we often want to chose value of the derivative from **the other side where the primal is defined.**
132132

0 commit comments

Comments
 (0)