Skip to content

Commit 85a83be

Browse files
committed
get rid of function def macro
1 parent affad43 commit 85a83be

File tree

1 file changed

+16
-20
lines changed

1 file changed

+16
-20
lines changed

src/rulesets/SparseArrays/sparsematrix.jl

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -80,27 +80,23 @@ if VERSION < v"1.7"
8080
end
8181
return ifelse(isodd(result), -1, 1)
8282
end
83-
84-
for itype in (:Int32, :Int64)
85-
@eval begin
86-
function LinearAlgebra.logabsdet(F::UmfpackLU{T, $itype}) where {T<:Union{Float64,ComplexF64}}
87-
n = checksquare(F)
88-
issuccess(F) || return log(zero(real(T))), zero(T)
89-
U = F.U
90-
Rs = F.Rs
91-
p = F.p
92-
q = F.q
93-
s = _signperm(p)*_signperm(q)*one(real(T))
94-
P = one(T)
95-
abs_det = zero(real(T))
96-
@inbounds for i in 1:n
97-
dg_ii = U[i, i] / Rs[i]
98-
P *= sign(dg_ii)
99-
abs_det += log(abs(dg_ii))
100-
end
101-
return abs_det, s * P
102-
end
83+
84+
function LinearAlgebra.logabsdet(F::UmfpackLU{T, TI}) where {T<:Union{Float64,ComplexF64},TI<:Union{Int32, Int64}}
85+
n = checksquare(F)
86+
issuccess(F) || return log(zero(real(T))), zero(T)
87+
U = F.U
88+
Rs = F.Rs
89+
p = F.p
90+
q = F.q
91+
s = _signperm(p)*_signperm(q)*one(real(T))
92+
P = one(T)
93+
abs_det = zero(real(T))
94+
@inbounds for i in 1:n
95+
dg_ii = U[i, i] / Rs[i]
96+
P *= sign(dg_ii)
97+
abs_det += log(abs(dg_ii))
10398
end
99+
return abs_det, s * P
104100
end
105101
end
106102

0 commit comments

Comments
 (0)