test more math

Author: oxinabox

src/rulesets/Base/base.jl

@@ -61,7 +61,7 @@
 @scalar_rule(\(x, y), (-(y / x / x), inv(x)))
 @scalar_rule(^(x, y), (y * x^(y - 1), Ω * log(x)))
 
-@scalar_rule(inv(x), -abs2(Ω))
+@scalar_rule(inv(x), -Ω^2)
 @scalar_rule(sqrt(x), inv(2 * Ω))
 @scalar_rule(cbrt(x), inv(3 * Ω^2))
 @scalar_rule(exp(x), Ω)

test/rulesets/Base/base.jl

@@ -43,8 +43,7 @@
             test_scalar(acsch, x)
             test_scalar(acoth, x + 1)
         end
-        @testset "Inverse degrees" begin
-            x = 0.5
+        @testset "Inverse degrees" for x = (0.5, Complex(0.5, 0.25))
             test_scalar(asind, x)
             test_scalar(acosd, x)
             test_scalar(atand, x)
@@ -73,40 +72,63 @@
             @test r === rsincos
             @test df(1, 2) === dsincos
         end
-    end
-    @testset "Misc. Tests" begin
-        @testset "*(x, y)" begin
-            x, y = rand(3, 2), rand(2, 5)
-            z, (dx, dy) = rrule(*, x, y)
+    end  # Trig
 
-            @test z == x * y
+    @testset "math" begin
+        for x in (-0.1, 6.4, 1.0+0.5im, -10.0+0im)
+            test_scalar(deg2rad, x)
+            test_scalar(rad2deg, x)
 
-            z̄ = rand(3, 5)
+            test_scalar(inv, x)
 
-            @test dx(z̄) == extern(accumulate(zeros(3, 2), dx, z̄))
-            @test dy(z̄) == extern(accumulate(zeros(2, 5), dy, z̄))
+            test_scalar(exp, x)
+            test_scalar(exp2, x)
+            test_scalar(exp10, x)
 
-            test_accumulation(rand(3, 2), dx, z̄, z̄ * y')
-            test_accumulation(rand(2, 5), dy, z̄, x' * z̄)
+            x isa Real && test_scalar(cbrt, x)
+            if (x isa Real && x >= 0) || x isa Complex
+                test_scalar(sqrt, x)
+                test_scalar(log, x)
+                test_scalar(log2, x)
+                test_scalar(log10, x)
+                test_scalar(log1p, x)
+            end
         end
-        @testset "hypot(x, y)" begin
-            x, y = rand(2)
-            h, dxy = frule(hypot, x, y)
+    end
 
-            @test extern(dxy(One(), Zero())) === x / h
-            @test extern(dxy(Zero(), One())) === y / h
+    @testset "*(x, y)" begin
+        x, y = rand(3, 2), rand(2, 5)
+        z, (dx, dy) = rrule(*, x, y)
 
-            cx, cy = cast((One(), Zero())), cast((Zero(), One()))
-            dx, dy = extern(dxy(cx, cy))
-            @test dx === x / h
-            @test dy === y / h
+        @test z == x * y
 
-            cx, cy = cast((rand(), Zero())), cast((Zero(), rand()))
-            dx, dy = extern(dxy(cx, cy))
-            @test dx === x / h * cx.value[1]
-            @test dy === y / h * cy.value[2]
-        end
+        z̄ = rand(3, 5)
+
+        @test dx(z̄) == extern(accumulate(zeros(3, 2), dx, z̄))
+        @test dy(z̄) == extern(accumulate(zeros(2, 5), dy, z̄))
+
+        test_accumulation(rand(3, 2), dx, z̄, z̄ * y')
+        test_accumulation(rand(2, 5), dy, z̄, x' * z̄)
     end
+
+    @testset "hypot(x, y)" begin
+        x, y = rand(2)
+        h, dxy = frule(hypot, x, y)
+
+        @test extern(dxy(One(), Zero())) === x / h
+        @test extern(dxy(Zero(), One())) === y / h
+
+        cx, cy = cast((One(), Zero())), cast((Zero(), One()))
+        dx, dy = extern(dxy(cx, cy))
+        @test dx === x / h
+        @test dy === y / h
+
+        cx, cy = cast((rand(), Zero())), cast((Zero(), rand()))
+        dx, dy = extern(dxy(cx, cy))
+        @test dx === x / h * cx.value[1]
+        @test dy === y / h * cy.value[2]
+    end
+
     @testset "identity" begin
         rng = MersenneTwister(1)
         n = 4