Merge pull request #320 from devmotion/patch-1

Only define rules for SpecialFunctions if needed

Author: oxinabox

Project.toml

@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "0.7.36"
+version = "0.7.37"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

src/ChainRules.jl

@@ -58,8 +58,12 @@ function __init__()
         include("rulesets/packages/NaNMath.jl")
     end
 
+    # Note: drop SpecialFunctions dependency in next breaking release
+    # https://github.com/JuliaDiff/ChainRules.jl/issues/319
     @require SpecialFunctions="276daf66-3868-5448-9aa4-cd146d93841b" begin
-        include("rulesets/packages/SpecialFunctions.jl")
+        if !isdefined(SpecialFunctions, :ChainRulesCore)
+            include("rulesets/packages/SpecialFunctions.jl")
+        end
     end
 end
 

test/rulesets/packages/SpecialFunctions.jl

@@ -1,5 +1,3 @@
-using SpecialFunctions
-
 @testset "SpecialFunctions" for x in (1.0, -1.0, 0.0, 0.5, 10.0, -17.1, 1.5 + 0.7im)
     test_scalar(SpecialFunctions.erf, x)
     test_scalar(SpecialFunctions.erfc, x)

test/runtests.jl

@@ -6,6 +6,7 @@ using ChainRulesTestUtils: rand_tangent, _fdm
 using Compat: only
 using FiniteDifferences
 using FiniteDifferences: rand_tangent
+using SpecialFunctions
 using LinearAlgebra
 using LinearAlgebra.BLAS
 using LinearAlgebra: dot
@@ -56,7 +57,11 @@ println("Testing ChainRules.jl")
 
         @testset "packages" begin
             include_test("rulesets/packages/NaNMath.jl")
-            include_test("rulesets/packages/SpecialFunctions.jl")
+            # Note: drop SpecialFunctions dependency in next breaking release
+            # https://github.com/JuliaDiff/ChainRules.jl/issues/319
+            if !isdefined(SpecialFunctions, :ChainRulesCore)
+                include_test("rulesets/packages/SpecialFunctions.jl")
+            end
         end
         println()
     end