Merge pull request #83 from nickrobinson251/npr/fdm-to-finitedifferences

Update FDM to FiniteDifferences

Author: nickrobinson251

Project.toml

@@ -11,15 +11,15 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
 ChainRulesCore = "^0.1"
-FDM = "^0.6"
+FiniteDifferences = "^0.7"
 julia = "^1.0"
 
 [extras]
-FDM = "e25cca7e-83ef-51fa-be6c-dfe2a3123128"
+FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000"
 NaNMath = "77ba4419-2d1f-58cd-9bb1-8ffee604a2e3"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["FDM", "Random", "Test", "SpecialFunctions", "NaNMath"]
+test = ["FiniteDifferences", "NaNMath", "Random", "SpecialFunctions", "Test"]

test/rulesets/LinearAlgebra/factorization.jl

@@ -48,9 +48,9 @@ using ChainRules: level2partition, level3partition, chol_blocked_rev, chol_unblo
                 @test dp isa ChainRules.DNERule
                 Ȳ = (p === :U ? UpperTriangular : LowerTriangular)(randn(rng, size(Y)))
                 # NOTE: We're doing Nabla-style testing here and avoiding using the `j′vp`
-                # machinery from FDM because that isn't set up to respect necessary special
-                # properties of the input. In the case of the Cholesky factorization, we
-                # need the input to be Hermitian.
+                # machinery from FiniteDifferences because that isn't set up to respect
+                # necessary special properties of the input. In the case of the Cholesky
+                # factorization, we need the input to be Hermitian.
                 X̄_ad = dot(dX(dF(Ȳ)), V)
                 X̄_fd = central_fdm(5, 1)() do ε
                     dot(Ȳ, getproperty(cholesky(X .+ ε .* V), p))

test/runtests.jl

@@ -1,6 +1,13 @@
-using ChainRules, Test, FDM, LinearAlgebra, LinearAlgebra.BLAS, Random, Statistics
 using Base.Broadcast: broadcastable
-import LinearAlgebra: dot
+using ChainRules
+using ChainRulesCore
+using FiniteDifferences
+using LinearAlgebra
+using LinearAlgebra.BLAS
+using LinearAlgebra: dot
+using Random
+using Statistics
+using Test
 
 # For testing purposes we use a lot of
 using ChainRulesCore: add, cast, extern, accumulate, accumulate!, store!, @scalar_rule,

test/test_util.jl

@@ -1,4 +1,4 @@
-using FDM: jvp, j′vp
+using FiniteDifferences: jvp, j′vp
 
 const _fdm = central_fdm(5, 1)