wip

Author: oxinabox

src/rulesets/Base/base.jl

@@ -1,5 +1,7 @@
 @scalar_rule(one(x), Zero())
 @scalar_rule(zero(x), Zero())
+@scalar_rule(sign(x), Zero())
+
 @scalar_rule(abs2(x), Wirtinger(x', x))
 @scalar_rule(log(x), inv(x))
 @scalar_rule(log10(x), inv(x) / log(oftype(x, 10)))

src/rulesets/packages/SpecialFunctions.jl

@@ -3,7 +3,6 @@ using ChainRulesCore
 using ..SpecialFunctions
 
 
-@scalar_rule(SpecialFunctions.lgamma(x), SpecialFunctions.digamma(x))
 @scalar_rule(SpecialFunctions.erf(x), (2 / sqrt(π)) * exp(-x * x))
 @scalar_rule(SpecialFunctions.erfc(x), -(2 / sqrt(π)) * exp(-x * x))
 @scalar_rule(SpecialFunctions.erfi(x), (2 / sqrt(π)) * exp(x * x))
@@ -24,4 +23,19 @@ using ..SpecialFunctions
 @scalar_rule(SpecialFunctions.erfcx(x), (2 * x * Ω) - (2 / sqrt(π)))
 @scalar_rule(SpecialFunctions.dawson(x), 1 - (2 * x * Ω))
 
+# Changes between SpecialFunctions 0.7 and 0.8
+if isdefined(SpecialFunctions, :lgamma)
+    # actually is the absolute value of the logorithm of gamma
+    @scalar_rule(SpecialFunctions.lgamma(x), SpecialFunctions.digamma(x))
+end
+
+if isdefined(SpecialFunctions, :logabsgamma)
+    # actually is the absolute value of the logorithm of gamma, paired with sign gamma
+    @scalar_rule(SpecialFunctions.logabsgamma(x), SpecialFunctions.digamma(x), Zero())
+end
+
+if isdefined(SpecialFunctions, :loggamma)
+    @scalar_rule(SpecialFunctions.loggamma(x), SpecialFunctions.digamma(x))
+end
+
 end #module

test/rulesets/Base/base.jl

@@ -166,4 +166,23 @@
         test_scalar(one, x)
         test_scalar(zero, x)
     end
+
+    @testset "sign" begin
+        @testset "at points" for x in (-1.1, -1.1, 0.5, 100)
+            test_scalar(sign, x)
+        end
+
+        @testset "Zero over the point discontinuity" begin
+            # Can't do finite differencing because we are lying
+            # following the subgradient convention.
+            
+            _, pb = rrule(sign, 0.0)
+            _, x̄ = pb(10.5)
+            @test extern(x̄) == 0
+
+            _, pf = frule(sign, 0.0)
+            ẏ = pf(NamedTuple(), 10.5)
+            @test extern(ẏ) == 0
+        end
+    end
 end

test/rulesets/packages/SpecialFunctions.jl

@@ -1,5 +1,5 @@
 using SpecialFunctions
-
+#=
 @testset "SpecialFunctions" for x in (1, -1, 0, 0.5, 10, -17.1, 1.5 + 0.7im)
     test_scalar(SpecialFunctions.erf, x)
     test_scalar(SpecialFunctions.erfc, x)
@@ -31,6 +31,24 @@ using SpecialFunctions
         test_scalar(SpecialFunctions.gamma, x)
         test_scalar(SpecialFunctions.digamma, x)
         test_scalar(SpecialFunctions.trigamma, x)
-        test_scalar(SpecialFunctions.lgamma, x)
     end
 end
+=#
+@testset "log gamma and co" begin
+    # SpecialFunctions 0.7->0.8 changes:
+    for x in (1.5, 2.5, 10.5, -0.6, -2.6, 1.6+1.6im, 1.6-1.6im, -4.6+1.6im)
+        if isdefined(SpecialFunctions, :lgamma)
+            test_scalar(SpecialFunctions.lgamma, x)
+        end
+        if isdefined(SpecialFunctions, :loggamma)
+            isreal(x) && x < 0 && continue
+            test_scalar(SpecialFunctions.loggamma, x)
+        end
+
+        if isdefined(SpecialFunctions, :logabsgamma)
+            isreal(x) || continue
+            
+        end
+    end
+
+end

test/runtests.jl

@@ -22,11 +22,11 @@ println("Testing ChainRules.jl")
     @testset "rulesets" begin
         @testset "Base" begin
             include(joinpath("rulesets", "Base", "base.jl"))
-            include(joinpath("rulesets", "Base", "array.jl"))
-            include(joinpath("rulesets", "Base", "mapreduce.jl"))
-            include(joinpath("rulesets", "Base", "broadcast.jl"))
+            #include(joinpath("rulesets", "Base", "array.jl"))
+            #include(joinpath("rulesets", "Base", "mapreduce.jl"))
+            #include(joinpath("rulesets", "Base", "broadcast.jl"))
         end
-
+        #==
         print(" ")
 
         @testset "Statistics" begin
@@ -41,6 +41,7 @@ println("Testing ChainRules.jl")
             include(joinpath("rulesets", "LinearAlgebra", "factorization.jl"))
             include(joinpath("rulesets", "LinearAlgebra", "blas.jl"))
         end
+        ==#
 
         print(" ")