Skip to content

Fix OncePerTask usage with datatypes for --trim #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

Fix OncePerTask usage with datatypes for --trim #197

merged 2 commits into from
Apr 25, 2025

Conversation

fredrikekre
Copy link
Contributor

No description provided.

@quinnj
Copy link
Member

quinnj commented Apr 25, 2025

Can you give me quick why here just for my own understanding?

@fredrikekre
Copy link
Contributor Author

Since there are no constructors for ::Type{T} we end up with the generic DataType as the initializer:

julia> OncePerTask{BigFloat}(BigFloat)
(::OncePerTask{BigFloat, DataType}) (generic function with 1 method)

julia> OncePerTask{BigFloat}(() -> BigFloat())
(::OncePerTask{BigFloat, var"#19#20"}) (generic function with 1 method)

This should perhaps be fixed in Base but fixing it here has less inertia for now :)

@quinnj
Copy link
Member

quinnj commented Apr 25, 2025

Sounds good. As soon as github stops spinning, we can merge; need a new release w/ this?

@quinnj
Copy link
Member

quinnj commented Apr 25, 2025

image

@fredrikekre
Copy link
Contributor Author

Yea, I have pushed another commit to my branch to bump the version but that isn't visible on this PR for some reason. Let me try to force push...

@quinnj quinnj merged commit 6352c4b into JuliaData:main Apr 25, 2025
12 checks passed
@fredrikekre fredrikekre deleted the fe/trim branch April 25, 2025 14:12
topolarity added a commit to topolarity/julia that referenced this pull request Apr 29, 2025
@topolarity
OncePerX: Improve initializer type for DataTypes
f48482f 
Generalized from JuliaData/Parsers.jl#197
@topolarity topolarity mentioned this pull request Apr 29, 2025
Merged
inkydragon pushed a commit to JuliaLang/julia that referenced this pull request Apr 30, 2025
@topolarity
OncePerX: Improve initializer type for DataType constructors (#58265)
1f18391 
Generalized from JuliaData/Parsers.jl#197
KristofferC pushed a commit to JuliaLang/julia that referenced this pull request May 5, 2025
@topolarity @KristofferC
OncePerX: Improve initializer type for DataType constructors (#58265)
bcc885c 
Generalized from JuliaData/Parsers.jl#197

(cherry picked from commit 1f18391)
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
@topolarity @charleskawczynski
OncePerX: Improve initializer type for DataType constructors (JuliaLa…
e6f2b92 
…ng#58265)

Generalized from JuliaData/Parsers.jl#197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @quinnj