Make sure we ignore opening/closing quotes when considering missing values. Fixes JuliaData/CSV.jl#454

Author: quinnj

src/Parsers.jl

@@ -233,7 +233,7 @@ end
         if eof(source, pos, len)
             code |= EOF
         end
-    elseif sentinel === missing && pos == startpos
+    elseif sentinel === missing && pos == vstartpos
         code &= ~(OK | INVALID)
         code |= SENTINEL
     end

src/strings.jl

@@ -243,7 +243,7 @@
     if sentinel !== nothing && sentinel !== missing && sentstart == vstartpos && sentinelpos == vpos
         # if we matched a sentinel value that was as long or longer than our type value
         code |= SENTINEL
-    elseif sentinel === missing && startpos == vpos
+    elseif sentinel === missing && vstartpos == vpos
         code |= SENTINEL
     else
         code |= OK

test/runtests.jl

@@ -378,6 +378,13 @@ showerror(io, e2)
 @test Parsers.quotednotescaped(QUOTED)
 @test !Parsers.quotednotescaped(QUOTED | ESCAPED_STRING)
 
+# https://github.com/JuliaData/CSV.jl/issues/454
+x, code, vpos, vlen, tlen = Parsers.xparse(Float64, "\"\"", 1, 2)
+@test Parsers.sentinel(code)
+
+x, code, vpos, vlen, tlen = Parsers.xparse(String, "\"\"", 1, 2)
+@test Parsers.sentinel(code)
+
 end # @testset "misc"
 
 include("floats.jl")