Properly account for pointer offset for non IOBuffers when parsing Strings. Fixes JuliaData/CSV.jl#345

Author: quinnj

src/strings.jl

@@ -25,8 +25,8 @@ Base.isequal(x::Tuple{Ptr{UInt8}, Int}, y::String) = hash(x) === hash(y)
 Base.convert(::Type{String}, x::Tuple{Ptr{UInt8}, Int}) = unsafe_string(x[1], x[2])
 
 const BUF = IOBuffer()
-getptr(io::IO, pos) = pointer(BUF.data, 1)
-getptr(io::IOBuffer, pos) = pointer(io.data, pos+1)
+getptr(io::IO, pos, ptroff) = pointer(BUF.data, 1)
+getptr(io::IOBuffer, pos, ptroff) = pointer(io.data, pos+1) + ptroff
 incr(io::IO, b) = Base.write(BUF, b)
 incr(io::IOBuffer, b) = 1
 
@@ -155,7 +155,7 @@ incr(io::IOBuffer, b) = 1
     end
     # @debug "node=$node"
     eof(io) && (code |= EOF)
-    ptr = getptr(io, pos) + ptroff
+    ptr = getptr(io, pos, ptroff)
     if match!(node, ptr, len)
         code |= SENTINEL
         setfield!(r, 1, missing)

test/runtests.jl

@@ -649,6 +649,20 @@ let io=IOBuffer("1,2,null,4"), layers=Parsers.Delimited(Parsers.Quoted(Parsers.S
     @test r.pos == 9
 end
 
+# https://github.com/JuliaData/CSV.jl/issues/345
+open("temp", "w+") do io
+    write(io, "\"DALLAS BLACK DANCE THEATRE\",")
+end
+
+let layers=Parsers.Delimited(Parsers.Quoted(Parsers.Sentinel(["null"])))
+    open("temp") do io
+        r = Parsers.parse(layers, io, String)
+        @test r.result == "DALLAS BLACK DANCE THEATRE"
+        @test r.code === OK | QUOTED | DELIMITED | EOF
+    end
+end
+rm("temp")
+
 # https://github.com/JuliaData/CSV.jl/issues/344
 open("temp", "w+") do io
     write(io, "1,2,null,4")