fix some deprecations (#106)

* update ind(min|max) to arg(min|max)

* update uninitialized to undef

* fix using A.B deprecation warning for non-modules

* use Compat instead of VERSION-dancing

* contains(haystack, needle) -> occursin(needle, haystack)

* STDERR -> stderr

Author: fredrikekre

REQUIRE

@@ -1,3 +1,3 @@
 julia 0.6
-Compat 0.51.0
+Compat 0.62.0
 JSON

src/BenchmarkTools.jl

@@ -6,9 +6,8 @@ using Compat
 using JSON
 using Base.Iterators
 
-if VERSION >= v"0.7.0-DEV.3052"
-    using Printf
-end
+using Compat.Printf
+
 
 const BENCHMARKTOOLS_VERSION = v"0.2.2"
 

src/execution.jl

@@ -132,7 +132,7 @@ end
 # the logistic function is useful for determining `evals` for `1 < t < RESOLUTION`
 logistic(u, l, k, t, t0) = round(Int, ((u - l) / (1 + exp(-k * (t - t0)))) + l)
 
-const EVALS = Vector{Int}(uninitialized, 9000) # any `t > length(EVALS)` should get an `evals` of 1
+const EVALS = Vector{Int}(undef, 9000) # any `t > length(EVALS)` should get an `evals` of 1
 for t in 1:400    (EVALS[t] = logistic(1006, 195, -0.025, t, 200)) end # EVALS[1] == 1000, EVALS[400] == 200
 for t in 401:1000 (EVALS[t] = logistic(204, -16, -0.01, t, 800))   end # EVALS[401] == 200, EVALS[1000] == 10
 for i in 1:8      (EVALS[((i*1000)+1):((i+1)*1000)] = 11 - i)      end # linearly decrease from EVALS[1000]

src/serialization.jl

@@ -1,6 +1,4 @@
-if VERSION >= v"0.7.0-DEV.2437"
-    using Base.Meta.parse
-end
+using Base.Meta: parse
 
 const VERSIONS = Dict("Julia" => string(VERSION),
                       "BenchmarkTools" => string(BENCHMARKTOOLS_VERSION))
@@ -28,7 +26,7 @@ function recover(x::Vector)
     fields = x[2]::Dict
     T = eval(parse(typename))::Type
     fc = fieldcount(T)
-    xs = Vector{Any}(uninitialized, fc)
+    xs = Vector{Any}(undef, fc)
     for i = 1:fc
         ft = fieldtype(T, i)
         fn = String(fieldname(T, i))

src/trials.jl

@@ -109,12 +109,12 @@ end
 Base.copy(t::TrialEstimate) = TrialEstimate(copy(t.params), t.time, t.gctime, t.memory, t.allocs)
 
 function Base.minimum(trial::Trial)
-    i = indmin(trial.times)
+    i = argmin(trial.times)
     return TrialEstimate(trial, trial.times[i], trial.gctimes[i])
 end
 
 function Base.maximum(trial::Trial)
-    i = indmax(trial.times)
+    i = argmax(trial.times)
     return TrialEstimate(trial, trial.times[i], trial.gctimes[i])
 end
 

test/ExecutionTests.jl

@@ -3,11 +3,8 @@ module ExecutionTests
 using BenchmarkTools
 using Compat
 using Compat.Test
-if VERSION >= v"0.7.0-DEV.3019"
-    using IterativeEigensolvers
-elseif VERSION >= v"0.7.0-DEV.2655"
-    using IterativeEigenSolvers
-end
+
+using Compat.IterativeEigensolvers
 
 seteq(a, b) = length(a) == length(b) == length(intersect(a, b))
 
@@ -174,9 +171,9 @@ let fname = tempname()
         end
         s = read(fname, String)
         try
-            @test contains(s, r"[0-9.]+ \w*s \([0-9]* allocations?: [0-9]+ bytes\)")
+            @test occursin(r"[0-9.]+ \w*s \([0-9]* allocations?: [0-9]+ bytes\)", s)
         catch
-            println(STDERR, "@btime output didn't match ", repr(s))
+            println(stderr, "@btime output didn't match ", repr(s))
             rethrow()
         end
     finally

test/SerializationTests.jl

@@ -89,7 +89,7 @@ end
             error("madness")
         catch err
             # This function thows a bunch of errors, so test for this specifically
-            @test contains(err.msg, "Unexpected JSON format")
+            @test occursin("Unexpected JSON format", err.msg)
         end
     end