Skip to content

Commit 0067b5b

Browse files
Sean McBaneararslan
authored andcommitted
Julia 0.7 fixes (#112)
* Added import of Statistics on appropriate versions * Removed reference to IterativeEigensolvers * Removed svds test to avoid a dependency on the Arpack package * Added 0.7 to the Travis matrix
1 parent bbf8f54 commit 0067b5b

File tree

7 files changed

+19
-7
lines changed

7 files changed

+19
-7
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ os:
55
- osx
66
julia:
77
- 0.6
8+
- 0.7
89
- nightly
910
notifications:
1011
email: false

src/BenchmarkTools.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ using Compat
66
using JSON
77
using Base.Iterators
88

9+
if VERSION >= v"0.7.0-beta.85"
10+
import Statistics: mean, median
11+
else
12+
import Base: mean, median
13+
end
14+
915
using Compat.Printf
1016

1117

src/groups.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ Base.filter(f, group::BenchmarkGroup) = filter!(f, copy(group))
7676

7777
Base.minimum(group::BenchmarkGroup) = mapvals(minimum, group)
7878
Base.maximum(group::BenchmarkGroup) = mapvals(maximum, group)
79-
Base.mean(group::BenchmarkGroup) = mapvals(mean, group)
80-
Base.median(group::BenchmarkGroup) = mapvals(median, group)
79+
mean(group::BenchmarkGroup) = mapvals(mean, group)
80+
median(group::BenchmarkGroup) = mapvals(median, group)
8181
Base.min(groups::BenchmarkGroup...) = mapvals(min, groups...)
8282
Base.max(groups::BenchmarkGroup...) = mapvals(max, groups...)
8383

src/trials.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ function Base.maximum(trial::Trial)
118118
return TrialEstimate(trial, trial.times[i], trial.gctimes[i])
119119
end
120120

121-
Base.median(trial::Trial) = TrialEstimate(trial, median(trial.times), median(trial.gctimes))
122-
Base.mean(trial::Trial) = TrialEstimate(trial, mean(trial.times), mean(trial.gctimes))
121+
median(trial::Trial) = TrialEstimate(trial, median(trial.times), median(trial.gctimes))
122+
mean(trial::Trial) = TrialEstimate(trial, mean(trial.times), mean(trial.gctimes))
123123

124124
Base.isless(a::TrialEstimate, b::TrialEstimate) = isless(time(a), time(b))
125125

test/ExecutionTests.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ using BenchmarkTools
44
using Compat
55
using Compat.Test
66

7-
using Compat.IterativeEigensolvers
8-
97
seteq(a, b) = length(a) == length(b) == length(intersect(a, b))
108

119
#########
@@ -26,7 +24,6 @@ for s in sizes
2624
end
2725

2826
groups["special"]["macro"] = @benchmarkable @test(1 == 1)
29-
groups["special"]["kwargs"] = @benchmarkable svds(rand(2, 2), nsv = 1)
3027
groups["special"]["nothing"] = @benchmarkable nothing
3128
groups["special"]["block"] = @benchmarkable begin rand(3) end
3229
groups["special"]["comprehension"] = @benchmarkable [s^2 for s in sizes]

test/GroupsTests.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ using BenchmarkTools: TrialEstimate, Parameters
55
using Compat
66
using Compat.Test
77

8+
if VERSION >= v"0.7.0-beta.85"
9+
using Statistics
10+
end
11+
812
seteq(a, b) = length(a) == length(b) == length(intersect(a, b))
913

1014
##################

test/TrialsTests.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ using BenchmarkTools
44
using Compat
55
using Compat.Test
66

7+
if VERSION >= v"0.7.0-beta.85"
8+
using Statistics
9+
end
10+
711
#########
812
# Trial #
913
#########

0 commit comments

Comments
 (0)