Switch to PythonCall for testing Python package

Author: giordano

.github/workflows/ci.yml

@@ -7,10 +7,6 @@ on:
   pull_request:
   release:
 
-env:
-  # `reproject=0.5` is not compatible with Python >= 3.8
-  PYTHON: "python3.7"
-
 jobs:
   test:
     name: Julia ${{ matrix.julia-version }} - ${{ matrix.os }} - ${{ matrix.julia-arch }}
@@ -19,13 +15,15 @@ jobs:
       fail-fast: false
       matrix:
         julia-version:
-          - "1.0"
+          - "1.6"
           - "1"
           - "nightly"
         os:
           - ubuntu-latest
-          - macos-latest
-          - windows-latest
+          ## macOS and Windows faile because of
+          ## https://github.com/cjdoris/PythonCall.jl/issues/165
+          # - macos-latest
+          # - windows-latest
         julia-arch:
           - x64
     steps:

CondaPkg.toml

@@ -0,0 +1,6 @@
+channels = ["astropy", "conda-forge"]
+
+[deps]
+python = "=3.7"
+astropy = "=4.3"
+reproject = "=0.5"

Project.toml

@@ -1,7 +1,7 @@
 name = "Reproject"
 uuid = "d1dcc2e6-806e-11e9-2897-3f99785db2ae"
 authors = ["Mosè Giordano", "Rohit Kumar"]
-version = "0.3.0"
+version = "0.3.1"
 
 [deps]
 FITSIO = "525bcba6-941b-5504-bd06-fd0dc1a4d2eb"
@@ -14,13 +14,4 @@ FITSIO = "0.15, 0.16"
 Interpolations = "0.13"
 SkyCoords = "0.4, 1"
 WCS = "0.5, 0.6"
-julia = "1"
-
-[extras]
-Conda = "8f4d0f93-b110-5947-807f-2305c1781a2d"
-PyCall = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0"
-SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
-Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
-
-[targets]
-test = ["Conda", "PyCall", "SHA", "Test"]
+julia = "1.6"

test/Project.toml

@@ -0,0 +1,12 @@
+[deps]
+FITSIO = "525bcba6-941b-5504-bd06-fd0dc1a4d2eb"
+PythonCall = "6099a3de-0909-46bc-b1f4-468b9a2dfc0d"
+SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+WCS = "15f3aee2-9e10-537f-b834-a6fb8bdb944d"
+
+[compat]
+FITSIO = "0.15, 0.16"
+PythonCall = "0.8"
+WCS = "0.5, 0.6"
+julia = "1.6"

test/core.jl

@@ -19,18 +19,21 @@ end
     download_dep("https://www.astropy.org/astropy-data/galactic_center/gc_msx_e.fits", "gc_msx_e.fits",
                  "3687fb3763911825f981e74b6a9b82c0e618f7e592b1e0cb17e2c63164e28cd6")
 
-    imgin = FITS(joinpath("data", "gc_msx_e.fits"))    # project this
-    imgout = FITS(joinpath("data", "gc_2mass_k.fits")) # into this coordinate
+    gc_msx_e = joinpath(@__DIR__, "data", "gc_msx_e.fits")
+    gc_2mass_k = joinpath(@__DIR__, "data", "gc_2mass_k.fits")
 
-    hdu1 = astropy.io.fits.open(joinpath("data", "gc_2mass_k.fits"))[1]
-    hdu2 = astropy.io.fits.open(joinpath("data", "gc_msx_e.fits"))[1]
+    imgin = FITS(gc_msx_e)    # project this
+    imgout = FITS(gc_2mass_k) # into this coordinate
 
-    @test isapprox(reproject(imgin, imgout, order = 0)[1]', rp.reproject_interp(hdu2, hdu1.header, order = 0)[1], nans = true, rtol = 1e-7)
-    @test isapprox(reproject(imgout, imgin, order = 0)[1]', rp.reproject_interp(hdu1, hdu2.header, order = 0)[1], nans = true, rtol = 1e-6)
-    @test isapprox(reproject(imgin, imgout, order = 1)[1]', rp.reproject_interp(hdu2, hdu1.header, order = 1)[1], nans = true, rtol = 1e-7)
-    @test isapprox(reproject(imgin, imgout, order = 2)[1]', rp.reproject_interp(hdu2, hdu1.header, order = 2)[1], nans = true, rtol = 6e-2)
+    hdu1 = astropy.io.fits.open(gc_2mass_k)[0]
+    hdu2 = astropy.io.fits.open(gc_msx_e)[0]
+
+    @test isapprox(reproject(imgin, imgout, order = 0)[1]', pyconvert(Matrix, rp.reproject_interp(hdu2, hdu1.header, order = 0)[0]), nans = true, rtol = 1e-7)
+    @test isapprox(reproject(imgout, imgin, order = 0)[1]', pyconvert(Matrix, rp.reproject_interp(hdu1, hdu2.header, order = 0)[0]), nans = true, rtol = 1e-6)
+    @test isapprox(reproject(imgin, imgout, order = 1)[1]', pyconvert(Matrix, rp.reproject_interp(hdu2, hdu1.header, order = 1)[0]), nans = true, rtol = 1e-7)
+    @test isapprox(reproject(imgin, imgout, order = 2)[1]', pyconvert(Matrix, rp.reproject_interp(hdu2, hdu1.header, order = 2)[0]), nans = true, rtol = 6e-2)
     @test isapprox(reproject(imgin[1], imgout[1], shape_out = (1000,1000))[1]',
-            rp.reproject_interp(hdu2, astropy.wcs.WCS(hdu1.header), shape_out = (1000,1000))[1], nans = true, rtol = 1e-7)
+                   pyconvert(Matrix, rp.reproject_interp(hdu2, astropy.wcs.WCS(hdu1.header), shape_out = (1000,1000))[0]), nans = true, rtol = 1e-7)
 
     wcs = WCSTransform(2; ctype = ["RA---AIR", "DEC--AIR"], radesys = "UNK")
     @test_throws ArgumentError reproject(imgin, wcs, shape_out = (100,100))

test/runtests.jl

@@ -1,11 +1,9 @@
 using Reproject
 using Test
-using Conda, PyCall
+using PythonCall
 using FITSIO, WCS
 using SHA: sha256
 
-Conda.add_channel("astropy")
-Conda.add("reproject=0.5")
 rp = pyimport("reproject")
 astropy = pyimport("astropy")