Skip to content

Commit d6e0fde

Browse files
authored
Fix norm of unitful quantities (#1125)
* Fix norm of unitful quantities * add Unitful test
1 parent 1b29fce commit d6e0fde

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

Project.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "StaticArrays"
22
uuid = "90137ffa-7385-5640-81b9-e52037218182"
3-
version = "1.5.13"
3+
version = "1.5.14"
44

55
[deps]
66
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
@@ -17,6 +17,7 @@ BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
1717
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
1818
OffsetArrays = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
1919
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
20+
Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
2021

2122
[targets]
22-
test = ["InteractiveUtils", "Test", "BenchmarkTools", "OffsetArrays"]
23+
test = ["InteractiveUtils", "Test", "BenchmarkTools", "OffsetArrays", "Unitful"]

src/linalg.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ end
265265
$(Expr(:meta, :inline))
266266
l = @inbounds sqrt($expr)
267267

268-
0<l<Inf && return l
268+
zero(l) < l && isfinite(l) && return l
269269
return _norm_scaled(Size(a), a)
270270
end
271271
end

test/runtests.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,5 @@ if TEST_GROUP ∈ ["", "all", "group-B"]
8080
addtests("flatten.jl")
8181
addtests("io.jl")
8282
addtests("svd.jl")
83+
addtests("unitful.jl")
8384
end

test/unitful.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
using Unitful
2+
3+
@testset "Unitful" begin
4+
# issue #1124
5+
@test norm(SVector(1.0*u"m")) == 1.0*u"m"
6+
end

0 commit comments

Comments
 (0)