Merge pull request #706 from mateuszbaran/mbaran/zero-dim-view

Views of zero-dimensional arrays

Author: andyferris

src/indexing.jl

@@ -378,4 +378,6 @@ Base.unsafe_view(A::AbstractArray, i1::StaticIndexing, indices::StaticIndexing..
 # Additionally, in some cases the SubArray constructor may be called directly
 # instead of unsafe_view so we need this method too (Base._maybe_reindex
 # is a good example)
-Base.SubArray(A::AbstractArray, indices::NTuple{<:Any,StaticIndexing}) = Base.SubArray(A, map(unwrap, indices))
+# the tuple indices has to have at least one element to prevent infinite
+# recursion when viewing a zero-dimensional array (see issue #705)
+Base.SubArray(A::AbstractArray, indices::Tuple{StaticIndexing, Vararg{StaticIndexing}}) = Base.SubArray(A, map(unwrap, indices))

test/indexing.jl

@@ -205,6 +205,14 @@ using StaticArrays, Test
         @test (zeros(2,0)[SVector(1),SVector{0,Int}()] = 0) == 0
     end
 
+    @testset "Viewing zero-dimensional arrays" begin
+        # issue #705
+        A = zeros()
+        B = MArray{Tuple{},Float64,0,1}(0.0)
+        @test @inferred(view(A))[] == 0.0
+        @test @inferred(view(B))[] == 0.0
+    end
+
     @testset "Using SArray as index for view" begin
         a = collect(11:20)
         @test view(a, SVector(1,2,3)) == [11,12,13]