Add error tests (#269)

* Add error tests, test_broken failing test

* Add tests for rand!

* Get rand for ranges working too

* A few more SDiag and linalg tests

* Fix lost Size

Author: kshyatt

src/arraymath.jl

@@ -58,6 +58,8 @@ end
 
 @inline rand(rng::AbstractRNG, range::AbstractArray, ::SA) where {SA <: StaticArray} = rand(rng, range, SA)
 @inline rand(rng::AbstractRNG, range::AbstractArray, ::Type{SA}) where {SA <: StaticArray} = _rand(rng, range, Size(SA), SA)
+@inline rand(range::AbstractArray, ::SA) where {SA <: StaticArray} = rand(Base.GLOBAL_RNG, range, SA)
+@inline rand(range::AbstractArray, ::Type{SA}) where {SA <: StaticArray} = _rand(Base.GLOBAL_RNG, range, Size(SA), SA)
 @generated function _rand(rng::AbstractRNG, range::AbstractArray, ::Size{s}, ::Type{SA}) where {s, SA <: StaticArray}
     v = [:(rand(rng, range)) for i = 1:prod(s)]
     return quote
@@ -66,6 +68,9 @@ end
     end
 end
 
+#@inline rand(rng::MersenneTwister, range::AbstractArray, ::SA) where {SA <: StaticArray} = rand(rng, range, SA)
+#@inline rand(rng::MersenneTwister, range::AbstractArray, ::Type{SA}) where {SA <: StaticArray} = _rand(rng, range, Size(SA), SA)
+
 @inline randn(rng::AbstractRNG, ::SA) where {SA <: StaticArray} = randn(rng, SA)
 @inline randn(rng::AbstractRNG, ::Type{SA}) where {SA <: StaticArray} = _randn(rng, Size(SA), SA)
 @generated function _randn(rng::AbstractRNG, ::Size{s}, ::Type{SA}) where {s, SA <: StaticArray}
@@ -123,6 +128,7 @@ end
 
 # ambiguity with AbstractRNG and non-Float64... possibly an optimized form in Base?
 @inline rand!(rng::MersenneTwister, a::SA) where {SA <: StaticArray{<:Any, Float64}} = _rand!(rng, Size(SA), a)
+@inline rand!(rng::MersenneTwister, a::SA) where {SA <: StaticArray{<:Tuple, Float64, <:Any}} = _rand!(rng, Size(SA), a)
 
 @inline randn!(rng::AbstractRNG, a::SA) where {SA <: StaticArray} = _randn!(rng, Size(SA), a)
 @generated function _randn!(rng::AbstractRNG, ::Size{s}, a::SA) where {s, SA <: StaticArray}

test/MArray.jl

@@ -65,6 +65,7 @@
         @test (ex = macroexpand(:(@MArray ones())); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@MArray fill(1))); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@MArray eye(5,6,7,8,9))); isa(ex, Expr) && ex.head == :error)
+        @test (ex = macroexpand(:(@MArray [1; 2; 3; 4]...)); isa(ex, Expr) && ex.head == :error)
 
         @test ((@MArray fill(3.,2,2,1))::MArray{Tuple{2,2,1}, Float64}).data === (3.0, 3.0, 3.0, 3.0)
         @test ((@MArray zeros(2,2,1))::MArray{Tuple{2,2,1}, Float64}).data === (0.0, 0.0, 0.0, 0.0)

test/MMatrix.jl

@@ -48,6 +48,7 @@
         @test (ex = macroexpand(:(@MMatrix ones)); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@MMatrix sin(1:5))); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@MMatrix eye(4, 5, 6, 7))); isa(ex, Expr) && ex.head == :error)
+        @test (ex = macroexpand(:(@MMatrix [1; 2; 3; 4]...)); isa(ex, Expr) && ex.head == :error)
 
         @test ((@MMatrix zeros(2,2))::MMatrix{2, 2, Float64}).data === (0.0, 0.0, 0.0, 0.0)
         @test ((@MMatrix fill(3.4, 2,2))::MMatrix{2, 2, Float64}).data === (3.4, 3.4, 3.4, 3.4)

test/MVector.jl

@@ -39,6 +39,7 @@
         @test (ex = macroexpand(:(@MVector sin(1:5))); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@MVector [i*j for i in 1:2, j in 2:3])); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@MVector Float32[i*j for i in 1:2, j in 2:3])); isa(ex, Expr) && ex.head == :error)
+        @test (ex = macroexpand(:(@MVector [1; 2; 3]...)); isa(ex, Expr) && ex.head == :error)
     end
 
     @testset "Methods" begin

test/SArray.jl

@@ -63,6 +63,7 @@
         @test (ex = macroexpand(:(@SArray fill())); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@SArray fill(1))); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@SArray eye(5,6,7,8,9))); isa(ex, Expr) && ex.head == :error)
+        @test (ex = macroexpand(:(@SArray [1; 2; 3; 4]...)); isa(ex, Expr) && ex.head == :error)
 
         @test ((@SArray fill(3.,2,2,1))::SArray{Tuple{2,2,1}, Float64}).data === (3.0, 3.0, 3.0, 3.0)
         @test ((@SArray zeros(2,2,1))::SArray{Tuple{2,2,1}, Float64}).data === (0.0, 0.0, 0.0, 0.0)

test/SDiagonal.jl

@@ -80,25 +80,30 @@
         @test (b'*m)' ==  @SVector [22,-12,26,14]
 
         @test m\b == m2\b
-        
+
         @test b'/m == b'/m2
         @test_throws Exception b/m
         @test m*m == m2*m
-        
+
         @test ishermitian(m) == ishermitian(m2)
         @test ishermitian(m/2)
-        
+        m_ireal = SDiagonal(@SVector [11+0im, 12+0im, 13+0im, 14+0im])
+        @test ishermitian(m_ireal)
+
         @test isposdef(m) == isposdef(m2)
         @test issymmetric(m) == issymmetric(m2)
-        
+
         @test (2*m/2)' == m
         @test 2m == m + m
+        @test -(-m) == m
         @test m*0 == m - m
-        
+
         @test m*inv(m) == m/m == m\m == eye(SDiagonal{4,Float64})
-        
-        
-        
-        
+
+        @test factorize(m) == m
+        @test m*[1; 1; 1; 1] == [11; 12; 13; 14]
+        @test m\[1; 1; 1; 1] == [11; 12; 13; 14].\[1; 1; 1; 1]
+        @test SMatrix{4,4}(eye(4))*m == m
+        @test m*SMatrix{4,4}(eye(4)) == m
     end
-end
+end

test/SMatrix.jl

@@ -47,6 +47,7 @@
         @test (ex = macroexpand(:(@SMatrix ones)); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@SMatrix sin(1:5))); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@SMatrix eye(2, 3, 4, 5))); isa(ex, Expr) && ex.head == :error)
+        @test (ex = macroexpand(:(@SMatrix [1; 2; 3; 4]...)); isa(ex, Expr) && ex.head == :error)
 
         @test ((@SMatrix fill(1.3, 2,2))::SMatrix{2, 2, Float64}).data === (1.3, 1.3, 1.3, 1.3)
         @test ((@SMatrix zeros(2,2))::SMatrix{2, 2, Float64}).data === (0.0, 0.0, 0.0, 0.0)

test/SVector.jl

@@ -43,6 +43,7 @@
         @test (ex = macroexpand(:(@SVector sin(1:5))); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@SVector [i*j for i in 1:2, j in 2:3])); isa(ex, Expr) && ex.head == :error)
         @test (ex = macroexpand(:(@SVector Float32[i*j for i in 1:2, j in 2:3])); isa(ex, Expr) && ex.head == :error)
+        @test (ex = macroexpand(:(@SVector [1; 2; 3]...)); isa(ex, Expr) && ex.head == :error)
     end
 
     @testset "Methods" begin

test/arraymath.jl

@@ -35,4 +35,24 @@
         fill!(m, 3)
         @test all(m .== 3.)
     end
+    
+    @testset "rand()" begin
+        m = rand(1:2, SVector{3})
+        check = ((m .>= 1) .& (m .<= 2))
+        @test all(check)
+        m = rand(1:2, SMatrix{4, 4})
+        check = ((m .>= 1) .& (m .<= 2))
+        @test all(check)
+    end
+    
+    @testset "rand!()" begin
+        m = @MMatrix [0. 0.; 0. 0.]
+        rand!(m)
+        check = ((m .< 1.) .& (m .> 0.))
+        @test all(check)
+        m = @MMatrix [0. 0.; 0. 0.]
+        rand!(m, 1:2)
+        check = ((m .>= 1) .& (m .<= 2))
+        @test all(check)
+    end
 end

test/linalg.jl

@@ -83,7 +83,7 @@ using StaticArrays, Base.Test
         @test @inferred(cross(SVector(1,2,3), SVector(4,5,6))) === SVector(-3, 6, -3)
         @test @inferred(cross(SVector(1,2), SVector(4,5))) === -3
         @test @inferred(cross(SVector(UInt(1),UInt(2)), SVector(UInt(4),UInt(5)))) === -3
-
+        @test @inferred(cross(SVector(UInt(1),UInt(2),UInt(3)), SVector(UInt(4),UInt(5),UInt(6)))) === SVector(-3, 6, -3)
     end
 
     @testset "transpose() and conj()" begin