Merge pull request #170 from kshyatt/ksh/mrd

Fix a bug and add tests for mapreducedim

Author: SimonDanisch

src/mapreduce.jl

@@ -126,14 +126,15 @@ end
 end
 
 @generated function _mapreducedim(f, op, ::Size{S}, a::StaticArray, ::Type{Val{D}}, v0) where {S, D}
-    N = ndims(a)
+    N = length(S)
     Snew = ([n==D ? 1 : S[n] for n = 1:N]...)
 
     exprs = Array{Expr}(Snew)
     itr = [1:n for n = Snew]
     for i ∈ Base.product(itr...)
         expr = :v0
         for k = 1:S[D]
+            ik = collect(i)
             ik[D] = k
             expr = :(op($expr, f(a[$(ik...)])))
         end

test/mapreduce.jl

@@ -52,6 +52,9 @@
         a = @SArray rand(4,3)  # as of Julia v0.5, diff() for regular Array is defined only for vectors and matrices
         @test diff(a) == diff(a, Val{1}) == diff(a, 1)
         @test diff(a, Val{2}) == diff(a, 2)
+        
+        @test reducedim(max, a, Val{1}, -1.) == reducedim(max, a, 1, -1.)
+        @test reducedim(max, a, Val{2}, -1.) == reducedim(max, a, 2, -1.)
     end
 
     @testset "mapreduce" begin